programmfabrik / fylr-helm

A Helm-Chart for the fylr application

Apache License 2.0

0 stars 0 forks source link

update default OAuth2 clients #55

Closed KlausThornProgrammfabrik closed 3 months ago

KlausThornProgrammfabrik commented 3 months ago

Description

default OAuth2 client changed from "web-client" to "fylr-web-frontend"
adding optional OAuth2 clients to values.yaml
bugfix: indentation of optional oauth2 clients corrected in configmap representing fylr.yml
as clients are public, some secrets have been removed

How Has This Been Tested?

deployed in a kubernetes cluster
browser test confirms oauth2 still works between default client and server
output in /insepct/config confirms that default client and optional clients are changed
asset upload confirms that there are no obvious side effects harming basic fylr functionality

KlausThornProgrammfabrik commented 3 months ago

I received a review via non github-communication:

The PR Looks good to me, I've deployed a test instance and everything looks good