fix Snow Leopard or Lion check and default arch

programming-nu / nu

Nu is an interpreted Lisp that builds on the Objective-C runtime and Foundation framework.

http://programming-nu.github.io

Apache License 2.0

2.15k stars 236 forks source link

fix Snow Leopard or Lion check and default arch #101

Closed cho-m closed 1 year ago

cho-m commented 2 years ago

Was building on Monterey ARM and noticed that -arch x86_64 was getting added to build. Seemed to be from Snow Leopard or Lion check.

Seen when working on Homebrew fixes for ARM build: https://github.com/Homebrew/homebrew-core/pull/112070

cho-m commented 2 years ago

Looks like there is still an issue for recent x86_64 platforms as the fixed check breaks build due to adding -arch i386. Not sure where this is getting injected into build yet.

EDIT: This is because arch command returns i386 on x86_64 platforms.

huntermarchi commented 1 year ago

i can fix the issue