programming-team-code / programming_team_code_rust

rustaceans
Creative Commons Zero v1.0 Universal
2 stars 0 forks source link

Clippy and refactor #18

Closed lrvideckis closed 3 months ago

lrvideckis commented 3 months ago

also install oj-verify tool later in CI (right before running lib checker tests) so we don't have to wait for it to install to see the results of all the cargo checks

lrvideckis commented 3 months ago

I learned that since we have a single crate, on any commit, the entire crate is rebuild, so oj-verify tool thinks everything changed, and then reruns all tests

so we can either split up the lib to be one crate for each file (Pro: the only tests that will be rerun are for changed files in that commit), but I don't really want to do this

What I think we should do: just keep it as is, and have CI rerun every test on each commit. Con: we'll have to wait longer for CI. But we can always run individual tests locally and know the result faster;

Pro: we can completely remove the .verify-helper/timestamps.remote.json file (every test is rerun anyways, so no need to save this file); This file was pretty annoying to deal with (it caused merge conflicts)


other changes in this PR: