programminghistorian / jekyll

Jekyll-based static site for The Programming Historian
http://programminghistorian.org
516 stars 229 forks source link

Possible bug/obsolescence in Geoparsing English-Language Text with the Edinburgh Geoparser #1953

Closed jenniferisasi closed 1 year ago

jenniferisasi commented 3 years ago

I am reporting this lesson for review of a possible bug or obsolescence:

walshbr commented 3 years ago

What was the result it gave you? Was it just that it quietly failed and did nothing or was there an error message?

jenniferisasi commented 3 years ago

Sorry, I should know how to report bugs properly.

When I run the example in the lesson (text file 172172.txt in in folder), it works BUT I suspect it is because the output file is already there (you get it with the download). One doesn't notice anything, so to speak, except a javascript thing in the map later (that's another issue but not worried about it right now)

However, upon trying with another text in the in folder and my own text, the process just again says:

Screen Shot 2020-12-14 at 9 02 14 AM

And no output file is created.

walshbr commented 3 years ago

Cool! @svmelton this seems like a good candidate for the bug fixer pipeline, if we are still doing that.

anisa-hawes commented 2 years ago

Hello all,

I have started trying this lesson today (running macOS BigSur v.11.5.2), to see if I can better understand/reproduce the error @jenniferisasi encountered.

I actually ran into another problem, as early as the first example command. I applied the "patch" to the setup file as explained, but when I ran the command an error message popped up: “lxreplace” cannot be opened because the developer cannot be verified.

I clicked to cancel the error message, but found that this meant I was not able to move onwards through the tutorial because the out directory was empty.

I tried again without re-running the "patch" this time (I was wondering if it is still needed with geoparser-1.2) but I received another error pop-up. Different this time: “lxtransduce” cannot be opened because the developer cannot be verified.

Does anyone have any ideas?

hawc2 commented 1 year ago

@anisa-hawes @jenniferisasi I took a look at this. I wonder if the updated version of the program, version 1.2, released 07/07/2021, addresses some of the problems you encountered, but also creates new ones.

The software notes say this version "– Fixed map display; fixed timeline display; fixed installation on recent versions of MacOX; integrated top candidate option into processing; updated gazetteer lookup URL- Updated LTXML2 and RXP"

There's a few things that could be updated in this lesson (including the Patch section), and I'm struggling to get the geoparser to work consistently on Mac or for any of the commands after installation to work. I don't think this would be an easy lesson for someone from our team to fix, so what other options are available? Can we ask the author to revise the lesson?

anisa-hawes commented 1 year ago

Dear @hawc2. Thank you for testing this.

The steps of the maintenance workflow are outlined on out Wiki here: Achieving Sustainability: Lesson Maintenance Workflow.

Yes, we can contact the author. I found some contact details here and I could make initial contact, if you think that is suitable.

Or, we can move forwards from Step 3:

This was one thing I wanted to speak to you about: we currently have very few practitioners on our external assessors list. It would be good if we could try to build up a small network (2-3 people), ideally across EN, FR and PT. We have Jairo who has supported Lesson Maintenance for ES.

hawc2 commented 1 year ago

I see - it's worth a shot with the author. If not, I'd do both options for step 3, as finding a practitioner may take a while and putting up a warning in the meantime is probably a safe bet. Happy to help think of external practitioners, so just ping me when you need recommendations.

rivaquiroga commented 1 year ago

Hi everyone! I tried the 1.2 version on Linux. Unfortunately, I got stuck in the first example:

Warning: the map will be blank.  To correct this, you must set
the environment variable GEOPARSER_MAP_KEY to a valid Mapbox key

This warning means that the output looks like this:

Screenshot from 2022-11-03 10-29-08

The lesson says nothing about getting an access token to use the Mapbox API. So I checked their documentation. And it looks like you actually need one:

Screenshot from 2022-11-03 10-23-54

To create an account, you must provide your credit card details (even if you only use the free tier).

Screenshot from 2022-11-03 10-23-09

And that is something I will not do, so I dropped my attempt to follow this lesson.

I am not sure this is something our lessons should ask readers to do. Having a credit card should not be a requirement to use a lesson.

hawc2 commented 1 year ago

Yes, thanks @rivaquiroga. This is what happened to me too, I was confused why Mapbox wasn't brought up in the lesson. I agree with Riva, this makes the lesson problematic, and it's probably best to see what the author thinks about how it can be improved/adapted from here

anisa-hawes commented 1 year ago

Thank you @rivaquiroga – this is very useful.

anisa-hawes commented 1 year ago

I've written to the author this afternoon to ask if they (or a colleague in their team) has interest in contributing to an update/adaptation of this lesson.

In my email, I've outlined the problems we've encountered and explained that we feel the requirement to provide credit card details presents a barrier to many of our readers.

anisa-hawes commented 1 year ago

Dear all,

Good news: I've received a positive reply from the author.

Beatrice Alex explained that a change was made to the Geoparser in early 2022 which introduced Mapbox instead of Google Maps. The team at Edinburgh think they have now found a way to utilise Mapbox without the need to supply credit card information, and so they are hoping/planning to release a new version of the Geoparser.

The new release is likely to be ready at the end of December, or early in the new year. The author has expressed enthusiasm for updating this lesson at the same time, and I will be very happy to support them to implement the necessary changes.

In the meantime, I've prepared an alert-warning box in PR #2733 which we can apply to this lesson. I propose that I close this Issue when that alert box is in place.

I will open a new Issue when I begin working with the author to prepare and implement the updates.