search

programminghistorian / jekyll

Jekyll-based static site for The Programming Historian
http://programminghistorian.org
521 stars 229 forks source link

Topic Modelling on Windows Instructions #2167

Closed pao-chuan closed 3 years ago

pao-chuan commented 3 years ago

I've tested the lesson on Mac and the instructions are ok. But for Windows, the problem is Figure 1 to 3, which can't be followed through Windows 10 because the control panel has changed. One solution may be that we can add some instructions for Windows 10. The lesson: https://programminghistorian.org/en/lessons/topic-modeling-and-mallet

anisa-hawes commented 3 years ago

Thank you, @pao-chuan! Working through these steps, I can confirm that the Windows 10 interface looks identical to Windows 7 at steps illustrated by Figure 2

Screenshot 2021-09-01 at 14 27 01

and Figure 3

Screenshot 2021-09-01 at 15 05 27

The key difference is at Figure 1, where you open the Control Panel and navigate to Advanced System Settings.

Instead of Start Menu -> Control Panel -> System -> Advanced System Settings, the steps are:

  1. Click Start (Windows icon) or press Windows key and type "Control Panel"

    Screenshot 2021-09-01 at 14 22 42

  2. Within Control Panel, select System and Security

    Screenshot 2021-09-01 at 15 03 56

  3. In System and Security, begin to type "Advanced" into the search field (upper right). Choose "View advanced system settings" from the results.

    Screenshot 2021-09-01 at 15 04 49

So, if anything, I think only a minor adjustment is required here.

At line 181 of the .md file, where the lesson currently reads:

To create an environment variable in Windows 7, click on your Start Menu -> Control Panel -> System -> Advanced System Settings (Figures 1,2,3).

We could consider making the following change:

Or, in Windows 10, click Start (Windows icon) or press the Windows key on your keyboard then type "Control Panel". Within Control Panel, select System and Security. In System and Security, begin to type "Advanced" into the search field (upper right) and choose "View advanced system settings" from the results.

What do you think @svmelton? Do you think this change would be helpful? I can generate a PR if so. Do you feel it is necessary to replace the three screenshots for Figures 1-3? (we could use the new ones I’ve created)

(I note that the ES version already refers to Windows 10, although the interface looks a little different in the screenshots)

svmelton commented 3 years ago

Thank you for your work on this @Anisa-ProgHist! Yes, please generate a PR, and I think it would be helpful to replace the figures with the screenshots you've taken.