programminghistorian / jekyll

Jekyll-based static site for The Programming Historian
http://programminghistorian.org
516 stars 229 forks source link

Geoparsing Text with the Edinburgh Geoparser #648

Closed fortinma closed 6 years ago

fortinma commented 6 years ago

I think there is just a tiny bit of an explanation that may be using the wrong file name in the following area of this wonderful tutorial:

In the section called: "Extracting Geo-Resolution Output to TSV", I believe the command is ok, but in the explanation of the command, the wrong filename is maybe referenced:

This the command: "./bin/sys-i386-snow-leopard/lxprintf -e "ent[@type='location']" "%s\t%s\t%s\t%s\t%s\n" "normalize-space(parts/part)" "@gazref" "@in-country" "@lat" "@long" < ./out/172172.out.xml> ./out/172172.out.tsv"

But the explanation then says: "In the example above, the XML input file (containing the location entities) is ./out/burtons.out.xml, and the TSV file is ./out/172172.out.tsv."

I think the file "burtons.out.xml" should probably be listed as "172172.out.xml".

If I am missing something and and I am wrong, I do apologize for the trouble.

ianmilligan1 commented 6 years ago

Thanks @fortinma! Let me check with the author and look closer on Monday, we’ll be in touch soon. Appreciate the feedback on this.

bea-alex commented 6 years ago

Yes, you're right. Thanks for spotting that.

fortinma commented 6 years ago

No worries. Thanks for the great tutorial!