Review Ticket: Beginner's Guide to Twitter Data

[acrymble]

The Programming Historian has received the following tutorial on 'Beginner's Guide to Twitter Data' by @BCWrit. This lesson is now under review and can be read at:

http://programminghistorian.github.io/ph-submissions/lessons/beginners-guide-to-twitter-data

Please feel free to use the line numbers provided on the preview if that helps with anchoring your comments, although you can structure your review as you see fit.

@spapastamkou will act as editor. Her role is to solicit two reviews from the community and to manage the discussions, which should be held here on this forum.

Members of the wider community are also invited to offer constructive feedback which should post to this message thread, but they are asked to first read our Reviewer Guidelines (http://programminghistorian.org/reviewer-guidelines) and to adhere to our anti-harassment policy (below). We ask that all reviews stop after the second formal review has been submitted so that the author can focus on any revisions. I will make an announcement on this thread when that has occurred.

I will endeavor to keep the conversation open here on Github. If anyone feels the need to discuss anything privately, you are welcome to email me. You can always turn to @amandavisconti if you feel there's a need for an ombudsperson to step in.

Anti-Harassment Policy

This is a statement of the Programming Historian's principles and sets expectations for the tone and style of all correspondence between reviewers, authors, editors, and contributors to our public forums.

The Programming Historian is dedicated to providing an open scholarly environment that offers community participants the freedom to thoroughly scrutinize ideas, to ask questions, make suggestions, or to requests for clarification, but also provides a harassment-free space for all contributors to the project, regardless of gender, gender identity and expression, sexual orientation, disability, physical appearance, body size, race, age or religion, or technical experience. We do not tolerate harassment or ad hominem attacks of community participants in any form. Participants violating these rules may be expelled from the community at the discretion of the editorial board. If anyone witnesses or feels they have been the victim of the above described activity, please contact our Ombudsperson (@amandavisconti). Thank you for helping us to create a safe space.

[walshbr]

Oooh sorry - I was reading quickly and totally missed the context here. You're right! I'll be on the lookout for the pinging on the PR. Best - B

[alsalin]

Hi all - @svmelton is using this lesson as a training opportunity so we'll be working through publishing it in the next two weeks. Thanks for your patience!

[svmelton]

Hi @programminghistorian/technical-team — looks like there may be some issues displaying image files tableau-map.png, vlookup-search.png, last-values.png, special-paste-values.png, first-return-value.png, and decrease-decimal.png. They show up in the image folder and the syntax seems to be correct, but they aren't displaying in the preview. Could someone take a look?

[jenniferisasi]

@svmelton it might not be the only reason why they are not displaying, but the author or you need to scape the quote marks inside the alt= tag. Try using "for the ". Hope it works this way.

[svmelton]

Thanks, @jenniferisasi. When I used " for " in the caption= tag it seemed to cause a build error.

(Also, I submitted a PR to revert to the previous version because I accidentally committed directly to the branch. Apologies!)

[jenniferisasi]

My bad, @svmelton, I didn't explain myself well. You need to scape quotes when you are quoting inside the tags, but not the quote " to open and close a caption/title. etc. So for example in the image that is still not displaying:

img src="/ph-submissions/images/beginners-guide-to-twitter-data/special-paste-values.png" alt="Choose "Values" in the "Paste Special" menu."

You need to scape "Values" and "Paste Special" to

img src="/ph-submissions/images/beginners-guide-to-twitter-data/special-paste-values.png" alt="Choose "Values&quot; in the "Paste Special" menu."

I am marking the examples with the ` to scape the formatting for the comment; if I don't scape it with the formatting quotes, it conversts the"into a"` in the comment itself.

[Note: I got rid of the < > brackets for the example above cos otherwise it tries to display an image in this very comment. Something new learned.]

[svmelton]

:flushed: Of course, thank you for walking me through it! I'm guessing that was the problem, as all the image files that had errors had quotes in the alt text. I've updated the PR.

[spapastamkou]

The lesson is now published: https://programminghistorian.org/en/lessons/beginners-guide-to-twitter-data Thanks to authors, reviewers and PH editors @jenniferisasi @svmelton @acrymble @walshbr @alsalin who contributed to this ticket from @drjwbaker and me. I will now close this ticket.

[drjwbaker]

Congrats to @spapastamkou for guiding this to completion. Exemplary work!

[BCWrit]

The lesson is now published: https://programminghistorian.org/en/lessons/beginners-guide-to-twitter-data Thanks to authors, reviewers and PH editors @jenniferisasi @svmelton @acrymble @walshbr @alsalin who contributed to this ticket from @drjwbaker and me. I will now close this ticket.

Thank you everyone! It's been a real pleasure!