programminghistorian / ph-submissions

The repository and website hosting the peer review process for new Programming Historian lessons
http://programminghistorian.github.io/ph-submissions
137 stars 111 forks source link

Review Ticket: Jupyter Notebooks as Argument #251

Closed acrymble closed 4 years ago

acrymble commented 5 years ago

The Programming Historian has received the following tutorial on 'Jupyter Notebooks as Argument' by @quinnanya. This lesson is now under review and can be read at:

http://programminghistorian.github.io/ph-submissions/lessons/jupyter-notebooks

Please feel free to use the line numbers provided on the preview if that helps with anchoring your comments, although you can structure your review as you see fit.

@walshbr will act as editor for the review process. His role is to solicit two reviews from the community and to manage the discussions, which should be held here on this forum. He will first read through the lesson and provide feedback, to which the author will responded.

Members of the wider community are also invited to offer constructive feedback which should post to this message thread, but they are asked to first read our Reviewer Guidelines (http://programminghistorian.org/reviewer-guidelines) and to adhere to our anti-harassment policy (below). We ask that all reviews stop after the second formal review has been submitted so that the author can focus on any revisions. He will make an announcement on this thread when that has occurred.

He will endeavor to keep the conversation open here on Github. If anyone feels the need to discuss anything privately, you are welcome to email me or @walshbr. You can always turn to @amandavisconti if you feel there's a need for an ombudsperson to step in.

Anti-Harassment Policy

This is a statement of the Programming Historian's principles and sets expectations for the tone and style of all correspondence between reviewers, authors, editors, and contributors to our public forums.

The Programming Historian is dedicated to providing an open scholarly environment that offers community participants the freedom to thoroughly scrutinize ideas, to ask questions, make suggestions, or to requests for clarification, but also provides a harassment-free space for all contributors to the project, regardless of gender, gender identity and expression, sexual orientation, disability, physical appearance, body size, race, age or religion, or technical experience. We do not tolerate harassment or ad hominem attacks of community participants in any form. Participants violating these rules may be expelled from the community at the discretion of the editorial board. If anyone witnesses or feels they have been the victim of the above described activity, please contact our Ombudsperson (@amandavisconti). Thank you for helping us to create a safe space.

quinnanya commented 4 years ago

@walshbr The link to Sarah's repo should be working again, and I'm close to having something ready for an example R notebook! Should be able to send a pull request with the new R notebook tomorrow. Fingers crossed for publishing early next week?

jenniferisasi commented 4 years ago

Can't wait to see that R notebook!

quinnanya commented 4 years ago

@jenniferisasi Disclaimer: I still wouldn't claim to know any R. But Shawn Graham helped me get some R code from Andrew Piper's "Enumerations" running in a notebook so I could try out a few things, so my plan is to write more prose documentation (e.g. background and context, "and you can too", etc.) and go with that.

jenniferisasi commented 4 years ago

I yet have to read that book so...this could be a very good motivation :) Happy to help if needed (though Piper, Jockers, etc. 's R is beyond my reading level)

walshbr commented 4 years ago

Sounds good @quinnanya! It's in @svmelton's hands now, so just ping us whenever you get things ready to go.

quinnanya commented 4 years ago

@svmelton @walshbr I've sent a pull request for the new R notebook, and I've nudged Sarah about changing the permissions on her repo.

quinnanya commented 4 years ago

@svmelton @walshbr Thanks for merging the R changes! Sarah's fixed the permissions on her repo (https://github.com/sarahrahrah/Socialist-Realism-Project), so I think this is ready to go?

svmelton commented 4 years ago

Thanks @quinnanya! I'll let everyone know once the PR has been approved and the lesson is published.

svmelton commented 4 years ago

And we're live! Congrats to @quinnanya, Tassie, and David. Thanks to @walshbr for editing and @diyclassics and @jerielizabeth for reviewing.

walshbr commented 4 years ago

Cool! I will tweet from proghist in a bit.

walshbr commented 4 years ago

Done and will continue to publicize in the next few days. Please do the same!