programminghistorian / ph-submissions

The repository and website hosting the peer review process for new Programming Historian lessons
http://programminghistorian.github.io/ph-submissions
138 stars 113 forks source link

Unsupervised Learning and K-Means Clustering with Python #325

Closed hawc2 closed 3 years ago

hawc2 commented 3 years ago

The Programming Historian has received the following tutorial on 'Unsupervised Learning and K-Means Clustering with Python' by @thomjur. This lesson is now under review and can be read at:

Old slug: https://programminghistorian.github.io/ph-submissions/lessons/k-means-clustering-with-scikit-learn-in-python

Final url for submission lesson: https://programminghistorian.github.io/ph-submissions/lessons/clustering-with-scikit-learn-in-python

Please feel free to use the line numbers provided on the preview if that helps with anchoring your comments, although you can structure your review as you see fit.

I will act as editor for the review process. My role is to solicit two reviews from the community and to manage the discussions, which should be held here on this forum. I have already read through the lesson and provided feedback, to which the author has responded.

Members of the wider community are also invited to offer constructive feedback which should post to this message thread, but they are asked to first read our Reviewer Guidelines (http://programminghistorian.org/reviewer-guidelines) and to adhere to our anti-harassment policy (below). We ask that all reviews stop after the second formal review has been submitted so that the author can focus on any revisions. I will make an announcement on this thread when that has occurred.

I will endeavor to keep the conversation open here on Github. If anyone feels the need to discuss anything privately, you are welcome to email me.

Our dedicated Ombudsperson is (Ian Milligan - http://programminghistorian.org/en/project-team). Please feel free to contact him at any time if you have concerns that you would like addressed by an impartial observer. Contacting the ombudsperson will have no impact on the outcome of any peer review.

Anti-Harassment Policy

This is a statement of the Programming Historian's principles and sets expectations for the tone and style of all correspondence between reviewers, authors, editors, and contributors to our public forums.

The Programming Historian is dedicated to providing an open scholarly environment that offers community participants the freedom to thoroughly scrutinize ideas, to ask questions, make suggestions, or to requests for clarification, but also provides a harassment-free space for all contributors to the project, regardless of gender, gender identity and expression, sexual orientation, disability, physical appearance, body size, race, age or religion, or technical experience. We do not tolerate harassment or ad hominem attacks of community participants in any form. Participants violating these rules may be expelled from the community at the discretion of the editorial board. Thank you for helping us to create a safe space.

svmelton commented 3 years ago

@thomjur The DOI should be updated now! It's in the lesson and is https://doi.org/10.46430/phen0094

thomjur commented 3 years ago

Great, thank you!

thomjur commented 3 years ago

@anisa-hawes Hey again, I found two typos while skipping through my text this morning. I don't think it is necessary to correct them or even create a new version for this, but I still wanted to mention them. :-)

"whcih"

and "in or data" instead of "in our data"

Thanks!

anisa-hawes commented 3 years ago

Please accept my apologies for missing these errors, @thomjur. I'll make the corrections this morning.

thomjur commented 3 years ago

No worries, I also checked the proof several times and missed this. Have a nice weekend! :-)

anisa-hawes commented 3 years ago

Thank you, @thomjur! Are you on Twitter? We have Tweeted to promote your lesson, in case you'd like to share it with your network. I can also tag you in a follow-up message, if you let me know your Twitter handle.

thomjur commented 3 years ago

@anisa-hawes Thanks! Yes, I am now also following you with \@Juritho (and I will happily retweet this piece; however, I don't really have a community on Twitter since I am usually using one of my several troll accounts ^_^).

melaniewalsh commented 3 years ago

Congrats @thomjur! Great work, team! @hawc2 @svmelton @hluling @anisa-hawes

hluling commented 3 years ago

Congratulations!

hawc2 commented 3 years ago

Congratulations @thomjur! Your tutorial is really impressive!

Much thanks to @hluling and @melaniewalsh for working so carefully to ensure its clarity and rigor. And thanks to @anisa-hawes for meticulous copyediting!

It was a pleasure working with you all!