programminghistorian / ph-submissions

The repository and website hosting the peer review process for new Programming Historian lessons
http://programminghistorian.github.io/ph-submissions
139 stars 114 forks source link

Facial Recognition in Historical Photographs with Artificial Intelligence in Python #552

Closed giuliataurino closed 5 months ago

giuliataurino commented 1 year ago

The Programming Historian has received the following tutorial on 'Facial Recognition in Historical Photographs with Artificial Intelligence in Python' by @c-goldberg. This lesson is now under review and can be read at:

http://programminghistorian.github.io/ph-submissions/en/drafts/originals/facial-recognition-ai-python

Please feel free to use the line numbers provided on the preview if that helps with anchoring your comments, although you can structure your review as you see fit.

I will act as editor for the review process. My role is to solicit two reviews from the community and to manage the discussions, which should be held here on this forum. I have already read through the lesson and provided feedback, to which the author has responded.

Members of the wider community are also invited to offer constructive feedback which should post to this message thread, but they are asked to first read our Reviewer Guidelines (http://programminghistorian.org/reviewer-guidelines) and to adhere to our anti-harassment policy (below). We ask that all reviews stop after the second formal review has been submitted so that the author can focus on any revisions. I will make an announcement on this thread when that has occurred.

I will endeavor to keep the conversation open here on Github. If anyone feels the need to discuss anything privately, you are welcome to email me.

Our dedicated Ombudsperson is (Ian Milligan - http://programminghistorian.org/en/project-team). Please feel free to contact him at any time if you have concerns that you would like addressed by an impartial observer. Contacting the ombudsperson will have no impact on the outcome of any peer review.

Anti-Harassment Policy

This is a statement of the Programming Historian's principles and sets expectations for the tone and style of all correspondence between reviewers, authors, editors, and contributors to our public forums.

The Programming Historian is dedicated to providing an open scholarly environment that offers community participants the freedom to thoroughly scrutinize ideas, to ask questions, make suggestions, or to requests for clarification, but also provides a harassment-free space for all contributors to the project, regardless of gender, gender identity and expression, sexual orientation, disability, physical appearance, body size, race, age or religion, or technical experience. We do not tolerate harassment or ad hominem attacks of community participants in any form. Participants violating these rules may be expelled from the community at the discretion of the editorial board. Thank you for helping us to create a safe space.


anisa-hawes commented 1 year ago

Hello @giuliataurino. Can I help you to set up this lesson?

If you email me the Markdown file, the figure images, and any data assets, I'd be happy get them uploaded and generate the Preview for you.

c-goldberg commented 1 year ago

Hi Giulia,

I hope your summer is going well. I'm writing to see how things are going with my PH submission. If there is anything I can do to help at this stage, please let me know.

Best, Charlie

On Thu, Apr 20, 2023 at 11:41 AM Anisa Hawes @.***> wrote:

Hello @giuliataurino https://github.com/giuliataurino. Can I help you to set up this lesson?

If you email me the Markdown file, the figure images, and any data assets, I'd be happy get them uploaded and generate the Preview for you.

— Reply to this email directly, view it on GitHub https://github.com/programminghistorian/ph-submissions/issues/552#issuecomment-1516638694, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQTHPTQDQVC7XPDQLHFJT3XCFRMXANCNFSM6AAAAAAVUEY2GU . You are receiving this because you were mentioned.Message ID: @.***>

-- Charlie Goldberg Associate Professor of History Department of History, Philosophy, and Political Science Bethel University 3900 Bethel Drive Saint Paul, Minnesota 55112

anisa-hawes commented 1 year ago

Hello, @c-goldberg,

Thank you for your note. I have some queries about the files which accompany this lesson:

{% include figure.html filename="or-en-facial-recognition-ai-python-01.png" alt="Visual description of figure image" caption="Google Colab file hierarchy" %}

You can find a full preview of the submission here : http://programminghistorian.github.io/ph-submissions/en/drafts/originals/facial-recognition-ai-python

--

Key files are here:

--

In the meantime, I've set up your .pynb within our organisational Colab repository, and shared a link with you so that we can work on it together. (Could we usefully upload the .xml file to the notebook's Files?)

c-goldberg commented 1 year ago

Thanks so much, Anisa. Here are some replies to your queries. I will wait for confirmation from you before I change anything here.

anisa-hawes commented 1 year ago

Hello @c-goldberg.

Thank you for your notes, and for your reply to my email too.

  1. It would be ideal to provide links to the Yearbook datasets on Bethel's website. Is it possible to share direct URLs for each of the sample objects you've selected? We can create stable (archival) links to each of the PDFs. If you can share the links to the Yearbooks here, I'd be happy to add them to the Markdown file for you:
  1. I've uploaded the .xml file to our assets repository. /assets/facial-recognition-ai-python/haarcascade_frontalface_default.xml. Where do you propose we add in a download prompt/link within the lesson? Let me know, and I can add this.

  2. Please send me the images from your Google Drive by email. I can take care of processing (re-sizing and re-naming according to our conventions) and uploading these. I'll slot in placeholder text for the alt, so you can come back to this.

Thank you for your collaboration and patience.

Very best, Anisa

anisa-hawes commented 1 year ago

Hello @c-goldberg. Just noting here that I've saved a copy of the Colab notebook in our assets repository. My suggestion is that if we link to the notebook in the lesson, we link to this .ipynb asset. Readers then have the option to click the Open in Colab button if they want to.

If you need to make adjustments to the notebook during the editorial and review process, we can resave so that the two are in sync.

c-goldberg commented 1 year ago

Hi @anisa-hawes, here are my updates:

  1. Yearbook links: 1911 Yearbook 1921 Yearbook 1931 Yearbook 1941 Yearbook 1951 Yearbook 1961 Yearbook

2a. I think it makes sense to link to the xml file in the "Lesson Setup" section. We might replace the sentence, "You can also download a .zip folder containing all of these things here," with a specific reference to just the xml file? I think we'll need to change that sentence anyways since we are linking to each yearbook individually.

2b. I was also sent a smaller .zip of all ~70 issues in the Bethel yearbook collection (2.3 GB) by my librarian. I can send that to you for hosting by PH if you'd like. You'd just need to provide attribution back to BU.

  1. I will send the Google Drive images now via email.

Thanks! C

anisa-hawes commented 1 year ago

Thank you, @c-goldberg. I'm really happy with the solution of linking to the Yearbooks in Bethel's library.

I'll make that adjustment to the Setup section. I appreciate your advice here.

anisa-hawes commented 1 year ago

Hello @c-goldberg.

Thank you for sharing the additional images from your Google Drive. I've added these to the set already in our /images repository: https://github.com/programminghistorian/ph-submissions/commit/b6a31c79fffa6f21876e99a8a32da9163466233e.

I've replaced the links to Google Drive with formatted liquid syntax so that these images will display as part of your lesson: https://github.com/programminghistorian/ph-submissions/commit/64fb734ba1a9cdbdc8f2554009add4510937c422. I've added in placeholder text for alt- and captions, which you can add when you have a moment. (I'm happy for you to email me the alt- and captions, or post a comment with the information here in the Issue if you'd like me to add that in for you).

A couple of further adjustments:

If you'd like to run the experiment on a larger set of yearbooks, click here.

The file you direct to is a line graph showing Non-smiles and Smiles (smiles.png in the set you sent me). Did you intend to use another link here?

c-goldberg commented 1 year ago

Thanks, Anisa. Yes, I did mean to supply a different link, specifically the larger .zip of all of the yearbooks. Should we still pursue hosting that file, or, now that we're providing direct links to each issue of the test set, should we just direct this link to BU's larger yearbook collection?

I'm fine rewording that section. Broadly, how should I re-frame that? Assume readers are using the Colab notebook in conjunction with the tutorial?

anisa-hawes commented 1 year ago

Thank you, @c-goldberg. Apologies for the delay in replying to your message.

Yes, I don't think we need to pursue hosting the Yearbooks further as we now have direct links to the sample you've selected in Bethel's Library. I agree that it would be sensible to add a link to the broader Yearbook collection at Bethel at line 457. Would this be the link you'd suggest? https://cdm16120.contentdm.oclc.org/digital/collection/p16120coll2 If you agree, we could adjust that sentence so it reads:

If you'd like to run the experiment on a larger set of yearbooks, you can browse Bethel Yearbooks in their Digital Library.

For the Lesson Setup paragraph, how about:

This lesson is accompanied by [a Google Colab notebook](we'll add a link here) which is ready to run. I have pre-loaded the sample dataset and all the code you'll need. The [Preliminary Colab setup section](we'll add a link here) will help you to orientate yourself within Colab if you're new to the platform. Alternatively, you can download the following files and run the code on your own dedicated Python environment [...]

c-goldberg commented 1 year ago

Thanks, Anisa. Both of those suggestions look good to me.

anisa-hawes commented 1 year ago

Thank you, @c-goldberg. I've made those two adjustments: https://github.com/programminghistorian/ph-submissions/commit/f38c53eb2b12a76314e66d4c8c454abfe2de78c3.

Hello @giuliataurino. This lesson is ready for your initial edits. These notes on Editorial Considerations can help to guide your reading and feedback. Meanwhile, the Difficulty Matrix (lower down on the same page) can support your thinking about whether this lesson is best categorised as a beginner, intermediate or advanced.

giuliataurino commented 1 year ago

Hi both,

I'll share here my previous feedback along with additional comments.

Again, thank you @c-goldberg for your submission! I'm working on applications of computer vision on historical photographs and I found the lesson particularly relevant for digital humanities scholarships dealing with AI and archival records.

I think the lesson is ready to be shared with the reviewers. If @anisa-hawes agrees, I will move forward with the reviewing process.

Thank you both for your time and work!

Best,

Giulia

c-goldberg commented 1 year ago

Hi Giulia,

Thank you for providing this feedback. I'm happy to see it move to the next stage, if Anisa thinks so as well.

Best regards, Charlie

On Tue, Aug 29, 2023 at 11:22 AM Giulia Taurino @.***> wrote:

Hi both,

I'll share here my previous feedback along with additional comments.

Again, thank you @c-goldberg https://github.com/c-goldberg for your submission! I'm working on applications of computer vision on historical photographs and I found the lesson particularly relevant for digital humanities scholarships dealing with AI and archival records.

-

Overall, the lesson makes it easy for "entry-level" digital humanists to approach computer vision, while also offering additional insight to more expert practitioners in relation to specific ML tasks for media and historical research. I would still categorize it as intermediate, since it does require some basic knowledge of python and understanding of CV models. The The choice of running the code on Google Colab improves usability and inclusivity. Accessibility and sustainability of the lesson are harder to assess, since they are dependent on a variety of external factors, but the author's thorough tutorial makes it easy to detect possible sections that might require future updates. In particular, the author's clear description and contextualization of Haar Cascades and Deepface provides insight into the "longevity" of these algorithms, as well as their positioning in the context of state-of-the-art ML models. I believe @anisa-hawes https://github.com/anisa-hawes' suggestions and troubleshooting also improved the sustainability of the project.

As to the paragraphs and structure, the introduction (paragraphs 1-7) is well written and effective in explaining the relevance of computational methods in the context of humanistic research.

I particularly appreciated the paragraphs dedicated to the ethical challenges (44-48) of using pre-trained models.

Throughout the lesson, learning outcomes and prior technical skills are clearly stated, links to other PH lessons are well integrated in the text, and the digital methods are outlined step by step in a very organized way. The code works on my end, so I don't have any modification to suggest.

I think the lesson is ready to be shared with the reviewers. If @anisa-hawes https://github.com/anisa-hawes agrees, I will move forward with the reviewing process.

Thank you both for your time and work!

Best,

Giulia

— Reply to this email directly, view it on GitHub https://github.com/programminghistorian/ph-submissions/issues/552#issuecomment-1697771709, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQTHPWL74PWDJG4J2FZNFLXXYJNJANCNFSM6AAAAAAVUEY2GU . You are receiving this because you were mentioned.Message ID: @.***>

-- Charlie Goldberg Associate Professor of History Department of History, Philosophy, and Political Science Bethel University 3900 Bethel Drive Saint Paul, Minnesota 55112

anisa-hawes commented 1 year ago

Excellent! Thank you, @giuliataurino.

Hello @c-goldberg. Next: Giulia will update you here in the Issue with an introduction to the peer-reviewers who will be reading and responding to your lesson.

I'm here to support you at any time through the process if you have questions.

StevenVerstockt commented 1 year ago

In general, this is a very good tutorial for people who want to start with computer vision. The concept of AI bias is also well-explained and illustrated. The references to related work also help to understand the different aspects that are discussed in the tutorial and allow the participants to get a better understanding of them. The programming instructions are very detailed and clear, which will make it easy to follow the tutorial.

I really like the dataset that will be used. Definitely a good choice to illustrate some basic AI/computer vision concepts. Learning outcomes are also clear and are certainly doable/feasible for people with no/limited programming skills. A pose estimator could maybe also be interesting to add and study how portrait poses changed over time. I also like the use of Google Colab – in this way participants will not lose time with installing libraries etc.

From chatbots to art generators to tailor-made Spotify playlists, artificial intelligence and machine learning — with their superhuman aptitude for pattern recognition >> these examples do not relate to the proposal/research topic (in my opinion) – maybe better to update/change or remove this part.

giuliataurino commented 1 year ago

Thank you, @StevenVerstockt, for taking the time to review this submission!

@c-goldberg, let me know if you have questions while I look for a second reviewer.

Best,

Giulia

hawc2 commented 1 year ago

@c-goldberg just a brief update, Giulia is going on leave so @anisa-hawes and I will be stewarding this lesson through the rest of the review process. We're in the process of finding the second reviewer, hopefully I can report back to you soon. Thanks for your patience!

c-goldberg commented 1 year ago

Thanks for the update, Alex.

On Fri, Sep 29, 2023 at 11:16 AM Alex Wermer-Colan @.***> wrote:

@c-goldberg https://github.com/c-goldberg just a brief update, Giulia is going on leave so @anisa-hawes https://github.com/anisa-hawes and I will be stewarding this lesson through the rest of the review process. We're in the process of finding the second reviewer, hopefully I can report back to you soon. Thanks for your patience!

— Reply to this email directly, view it on GitHub https://github.com/programminghistorian/ph-submissions/issues/552#issuecomment-1741158871, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQTHPTLZ43ZJO5MDMA5GVDX43X7JANCNFSM6AAAAAAVUEY2GU . You are receiving this because you were mentioned.Message ID: @.***>

-- Charlie Goldberg Associate Professor of History Department of History, Philosophy, and Political Science Bethel University 3900 Bethel Drive Saint Paul, Minnesota 55112

hawc2 commented 1 year ago

@davanstrien has agreed to review this lesson in the next month. Thanks Daniel!

@c-goldberg, stay tuned, and hopefully you can make revisions in December

davanstrien commented 12 months ago

Thanks for this lesson and apologies for the delay in getting my review submitted. Please feel free to ping m if any of my comments are unclear.

General feedback

Notebook comments

Lesson comments:

General Comments:

Section comments:

anisa-hawes commented 12 months ago

Thank you for this thorough and thoughtful review, @davanstrien!


Hello @c-goldberg,

Now that we have received both reviews, I will read through both Steven and Daniel's comments and prepare a summary of their suggested revisions, so that you have a practical plan to move forwards.

I'm looking forward to working with you to shape this lesson for publication.

Very best, Anisa

c-goldberg commented 12 months ago

Thanks so much for this feedback! I'm grateful for the attention to detail, and I'm looking forward to the next steps.

On Fri, Dec 1, 2023 at 11:44 AM Anisa Hawes @.***> wrote:

Thank you for this thorough and thoughtful review, @davanstrien https://github.com/davanstrien!

Hello @c-goldberg https://github.com/c-goldberg,

Now that we have received both reviews, I will read through both Steven and Daniel's comments and prepare a summary of their suggested revisions, so that you have a practical plan to move forwards.

I'm looking forward to working with you to shape this lesson for publication.

Very best, Anisa

— Reply to this email directly, view it on GitHub https://github.com/programminghistorian/ph-submissions/issues/552#issuecomment-1836526906, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQTHPSZYO5JM5IW7N7IAX3YHIJQXAVCNFSM6AAAAAAVUEY2GWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZWGUZDMOJQGY . You are receiving this because you were mentioned.Message ID: @.***>

-- Charlie Goldberg Associate Professor of History Department of History, Philosophy, and Political Science Bethel University 3900 Bethel Drive Saint Paul, Minnesota 55112

giuliataurino commented 11 months ago

Hi @c-goldberg,

I'm back to work and just wanted to make sure you have received the reviews.

In addition to the feedback I previously shared, here is a summary of the reviewers' general suggestions (please refer to their comments above for more detailed changes to the text) to facilitate your work:

"-One query: at line 457, where you write:

If you'd like to run the experiment on a larger set of yearbooks, click here.

The file you direct to is a line graph showing Non-smiles and Smiles (smiles.png in the set you sent me). Did you intend to use another link here?

Feel free to send me your questions should you have any doubts on the reviews and modifications to the text.

Best,

Giulia

c-goldberg commented 11 months ago

Hi Giulia,

So sorry for the delay on my end and thanks for your patience. I'm preparing to lead a study abroad trip during our January term, and it has dominated my attention since the end of the fall semester. Unfortunately, I haven't found the time to give the reviewers' recommendations the attention they deserve and revise the tutorial before I leave. I'm hoping that you'd find it acceptable if I returned to this at the end of January when I return. Please let me know if that poses a problem for you.

Best wishes, Charlie

On Mon, Dec 18, 2023 at 11:59 AM Giulia Taurino @.***> wrote:

Hi @c-goldberg https://github.com/c-goldberg,

I'm back to work and just wanted to make sure you have received the reviews.

In addition to the feedback I previously shared, here is a summary of the reviewers' general suggestions (please refer to their comments above for more detailed changes to the text) to facilitate your work:

-[ ] Consider changing the phrase "From chatbots to art generators to tailor-made Spotify playlists, artificial intelligence and machine learning — with their superhuman aptitude for pattern recognition — become more ubiquitous by the day" by referencing examples in the field of facial recognition;

-[ ] Consider using 'machine learning' as a more specific term for the methods you are describing (as opposed to AI which is more generic). Alternatively, please clarify in a brief paragraph the relation between ML and AI (as in ML is a branch of AI) for non-expert audiences. For abbreviations, please introduce them when first mentioning machine learning (ML) and artificial intelligence (AI);

-

One reviewer suggested to broaden the discussion on bias by discussing not only the training sets used in ML, but also the data used for fine-tuning. This is a good point and might enrich the discussion you already bring up in the lesson. For instance, it might be a good idea to discuss the benefits, challenges and potential bias of using the corpus you selected;

Please make sure you addressed Anisa's points, as it follows:

"-One query: at line 457, where you write:

If you'd like to run the experiment on a larger set of yearbooks, click here https://drive.google.com/file/d/1oSA6RIBwe2hUvMCFZ65lgKJ7W1AqTHpW/view?usp=sharing .

The file you direct to is a line graph showing Non-smiles and Smiles (smiles.png in the set you sent me). Did you intend to use another link here?

  • One note: I think the sentence at line 55 might need adjustment. We want readers to work through this lesson to learn about the context, concepts and application of this method. Colab is one of tools they can choose to work with, and you’re facilitating that by setting up a notebook that is ready to use and providing guidance notes throughout. But many of our readers choose to work in their local development environments, even though (as you explain) it can be challenging to configure. And others will choose different cloud-hosted development environments."

Feel free to send me your questions should you have any doubts on the reviews and modifications to the text.

Best,

Giulia

— Reply to this email directly, view it on GitHub https://github.com/programminghistorian/ph-submissions/issues/552#issuecomment-1861200983, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQTHPQ7K3VSS72AETROUXTYKB76PAVCNFSM6AAAAAAVUEY2GWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRRGIYDAOJYGM . You are receiving this because you were mentioned.Message ID: @.***>

-- Charlie Goldberg Associate Professor of History Department of History, Philosophy, and Political Science Bethel University 3900 Bethel Drive Saint Paul, Minnesota 55112

hawc2 commented 10 months ago

@c-goldberg just checking in, will you be able to make these revisions before end of January?

c-goldberg commented 10 months ago

Hi Alex,

Yes! I am leading a study abroad trip in Europe for most of the month but it is top priority for me when I get back next week. Thank you for your patience.

Charlie

On Friday, January 19, 2024, Alex Wermer-Colan @.***> wrote:

@c-goldberg https://github.com/c-goldberg just checking in, will you be able to make these revisions before end of January?

— Reply to this email directly, view it on GitHub https://github.com/programminghistorian/ph-submissions/issues/552#issuecomment-1900982628, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQTHPXSBJUKJWW5JDZPTPTYPLCDBAVCNFSM6AAAAAAVUEY2GWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBQHE4DENRSHA . You are receiving this because you were mentioned.Message ID: @.***>

-- Charlie Goldberg Associate Professor of History Department of History, Philosophy, and Political Science Bethel University 3900 Bethel Drive Saint Paul, Minnesota 55112

giuliataurino commented 10 months ago

Hi @c-goldberg,

Thank you for the update. Let me know if you have any question about the revisions.

Best,

Giulia

c-goldberg commented 10 months ago

Hi @giuliataurino,

Two questions:

  1. For revisions to the tutorial text, should I simply update facial-recognition-ai-python.md on github? Or send along a revised markdown file with a different name?
  2. Similarly, for revisions to the Colab notebook, should I update facial_recognition_ai_python.ipynb, or make a new notebook? Thanks!

C

giuliataurino commented 10 months ago

Hi @c-goldberg,

I'll let @anisa-hawes confirm this, but you can revise and update directly facial-recognition-ai-python.md and facial_recognition_ai_python.ipynb on github.

Let me know if you have other questions.

Best,

Giulia

charlottejmc commented 10 months ago

Hello @c-goldberg,

Just to confirm:

Thank you very much,

Charlotte ✨

c-goldberg commented 10 months ago

Hello! Thanks so much, @charlottejmc. After failing to get my GitHub Desktop to clone the repo properly, I'd like to upload my revised .md file here if that's ok? I'm worried I might mess something up. PHGoldbergEdited.md

I've also updated the Colab notebook. If someone could verify that the changes I've made are visible, that'd be great.

Thanks to everyone for their patience. Please let me know if I can revise anything further.

Charlie

charlottejmc commented 10 months ago

Hi @c-goldberg,

c-goldberg commented 8 months ago

Hi all,

I'm hoping someone can provide me with an update on where things stand with my submission? I hope everyone is having a good spring semester.

Best, Charlie

On Wed, Jan 31, 2024 at 11:22 AM charlottejmc @.***> wrote:

Hi @c-goldberg https://github.com/c-goldberg,

— Reply to this email directly, view it on GitHub https://github.com/programminghistorian/ph-submissions/issues/552#issuecomment-1919564705, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQTHPXV2PUS6KRIG3XBLDTYRJ4WJAVCNFSM6AAAAAAVUEY2GWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJZGU3DINZQGU . You are receiving this because you were mentioned.Message ID: @.***>

-- Charlie Goldberg Associate Professor of History Department of History, Philosophy, and Political Science Bethel University 3900 Bethel Drive Saint Paul, Minnesota 55112

hawc2 commented 7 months ago

@c-goldberg now that you've completed your revisions, @giuliataurino will take one last look over the lesson, make sure you have adequately responded to the reviewer feedback, and then let you know if there are any additional edits.

Once @giuliataurino signs off on it, she'll send the lesson to me as Managing Editor for final review. I'll look it over, give you an additional round of feedback to standardize the lesson for ProgHist, and then once I approve those changes the lesson will be sent to our copyeditor. Thanks for your patience, and stay tuned for next steps!

giuliataurino commented 7 months ago

Hi @hawc2,

Thank you for your patience.

I confirm the author addressed the feedback and that the lesson is ready to be published. I don't think any additional edit is needed. As seen above, here is the link for your final review: https://programminghistorian.github.io/ph-submissions/en/drafts/originals/facial-recognition-ai-python#introduction.

Let me know if anything else is needed on my end.

Best,

Giulia

hawc2 commented 7 months ago

@c-goldberg I've had a chance to read through your lesson and do some basic line edits. I have a few coments for you, but before ask you to make a final round of revisions, I've asked our copyeditor @charlottejmc to make some adjustments to the lesson structure.

Charlotte will:

Once Charlotte is done with that, I'll give you a final set of edits, and once you complete those, the lesson will go into copyediting and preparation for publication.

charlottejmc commented 6 months ago

Thank you @hawc2, I've now implemented these changes in the lesson file and the Google Colab notebook.

@c-goldberg, please do let me know if you're happy with my edits! For the two sections ## PDF Conversion and ## Processing the Images, I decided to move the full code blocks up at the beginning, before letting your commentary run through them more closely below.

I also added in the two lines of code needed for the ## Download and Results section.

Thank you for your patience with this. ✨

c-goldberg commented 6 months ago

Thank you! This looks good to me.

On Fri, May 3, 2024 at 6:43 AM charlottejmc @.***> wrote:

Thank you @hawc2 https://github.com/hawc2, I've now implemented these changes in the lesson file https://github.com/programminghistorian/ph-submissions/blob/gh-pages/en/drafts/originals/facial-recognition-ai-python.md and the Google Colab notebook https://github.com/programminghistorian/ph-submissions/blob/gh-pages/assets/facial-recognition-ai-python/facial-recognition-ai-python.ipynb .

@c-goldberg https://github.com/c-goldberg, please do let me know if you're happy with my edits! For the two sections ## PDF Conversion and ## Processing the Images, I decided to move the full code blocks up at the beginning, before letting your commentary run through them more closely below.

I also added in the two lines of code needed for the ## Download and Results section.

Thank you for your patience with this. ✨

— Reply to this email directly, view it on GitHub https://github.com/programminghistorian/ph-submissions/issues/552#issuecomment-2092836285, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQTHPTWYAYHULHGR6QXI4LZANZ67AVCNFSM6AAAAAAVUEY2GWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSHAZTMMRYGU . You are receiving this because you were mentioned.Message ID: @.***>

-- Charlie Goldberg Associate Professor of History Department of History, Philosophy, and Political Science Bethel University 3900 Bethel Drive Saint Paul, Minnesota 55112

hawc2 commented 6 months ago

Thanks @charlottejmc for these excellent copy edits. The code looks much better integrated into the broader commentary of the lesson.

@c-goldberg I have a few remaining comments for final revisions, each of which should only require a few clarifying sentences here and there. Once you do this last round of edits, we'll move forward with publication.

Thanks for making these final revisions - the lesson is looking really compelling! Once you make these changes, we’ll prep for publication.

c-goldberg commented 6 months ago

Hi Alex, Thanks for these edits! I've completed my revisions. I've pushed changes (I hope correctly!).

One note about terminology: I'm favoring keeping both AI and ML in the lesson, mainly because I think "Artificial Intelligence" in the title would make the lesson more visible, so I've tried to be more consistent with abbreviations and describing the relationship between the two.

Please let me know if I can do anything else!

c-goldberg commented 6 months ago

Actually, I'm thinking my changes did not push correctly. I've uploaded the file here. Can someone help? Thanks! PHGoldberg3.md

anisa-hawes commented 6 months ago

Hello @c-goldberg. Yes, of course. I can help 🙂

hawc2 commented 6 months ago

Perfect, thank you @c-goldberg. All your edits look great. @anisa-hawes @charlottejmc once you wrap up any last copyedits, this leson should be ready for moving over to the Jekyll site for publication!

anisa-hawes commented 6 months ago

Hello again @c-goldberg. I've committed the edits on your behalf: https://github.com/programminghistorian/ph-submissions/commit/0ca541cfea3a2194d4e5cd9eb6ec4ab71002fa2a.

If you and @hawc2 are both happy, we'll move forwards to copyediting by @charlottejmc. Although Charlotte assisted with revisions to the Broad Brushstrokes section and lesson structure (following Alex's suggestions) we have't done a full copyedit yet so we will set to work on that next week. You'll also have an opportunity to discuss any copyedits we suggest with @giuliataurino and @hawc2.

Finally, we will coordinate a series of final tasks including: typesetting, generating archival links, collating copyright agreements, reviewing and gathering essential metadata.

Then we'll move forwards to publication! ✨

We are grateful for your patience and collaboration.

c-goldberg commented 6 months ago

Wonderful. Thanks to everyone for their hard work!

On Fri, May 17, 2024 at 11:18 AM Anisa Hawes @.***> wrote:

Hello again @c-goldberg https://github.com/c-goldberg. I've committed the edits on your behalf: 0ca541c https://github.com/programminghistorian/ph-submissions/commit/0ca541cfea3a2194d4e5cd9eb6ec4ab71002fa2a .

If you and @hawc2 https://github.com/hawc2 are both happy, we'll move forwards to copyediting by @charlottejmc https://github.com/charlottejmc. Although Charlotte assisted with revisions to the Broad Brushstrokes section and lesson structure (following Alex's suggestions) we have't done a full copyedit yet so we will set to work on that next week. You'll also have an opportunity to discuss any copyedits we suggest with @giuliataurino https://github.com/giuliataurino and @hawc2 https://github.com/hawc2.

Finally, we will coordinate a series of final tasks including: typesetting, generating archival links, collating copyright agreements, reviewing and gathering essential metadata.

Then we'll move forwards to publication! ✨

We are grateful for your patience and collaboration.

— Reply to this email directly, view it on GitHub https://github.com/programminghistorian/ph-submissions/issues/552#issuecomment-2117943067, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQTHPSCFOGQ6SS7OY5UEG3ZCYUWDAVCNFSM6AAAAAAVUEY2GWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJXHE2DGMBWG4 . You are receiving this because you were mentioned.Message ID: @.***>

-- Charlie Goldberg Associate Professor of History Department of History, Philosophy, and Political Science Bethel University 3900 Bethel Drive Saint Paul, Minnesota 55112

charlottejmc commented 6 months ago

Hello @c-goldberg,

This lesson is now with me for copyediting. I aim to complete the work by Friday 31 May.

@c-goldberg, please note that you won't have direct access to make further edits to your files during this phase.

Any further revisions can be discussed with your editor @giuliataurino after my copyedits are complete.

Thank you for your understanding.

anisa-hawes commented 6 months ago

Hello @c-goldberg,

Thank you for reviewing Charlotte's copyedits. We're delighted that you're happy with the lesson.

The final stage for us ahead of publication is a series of tasks to support sustainability + accessibility including: typesetting, generating archival links, collating copyright agreements, and reviewing essential metadata. There are two things we need your and Zach's input on, and we'll point to those in our checklist below.

--

Hello @hawc2,

This lesson's sustainability + accessibility checks are in progress.

http://programminghistorian.github.io/ph-submissions/en/drafts/originals/facial-recognition-ai-python

Publisher's sustainability + accessibility actions:

Hello @c-goldberg, Our authorial copyright declaration form is an opportunity to acknowledge copyright and grant us permission to publish the lesson. For lessons that are co-authored/translated, we only require one lead author/translator to complete the form. Could you download this, complete the details, and email it to Charlotte (publishing.assistant [@] programminghistorian.org)?. Many thanks.

Authorial / editorial input to YAML:

Hello @c-goldberg, I've noticed that the figure images are still missing 'alt-text'. This descriptive element enables screen readers to read the information conveyed in the images for people with visual impairments, different learning abilities, or who cannot otherwise view them, for example due to a slow internet connection. It's important to say that alt-text should go further than repeating the figure captions. Could you please replace the placeholder (which currently says 'Visual description of figure image') with these short descriptions? Please let me know if you'd like any additional guidance with this.

The image must be:

- name: Zach Haala
  team: false
  bio:
    en: |
      Zach Haala graduated with a bachelor’s degree in Software Engineering and Digital Humanities from Bethel University in 2023. He is a Business Systems Analyst at Optum.

Files we are preparing for transfer to Jekyll:

Promotion:

charlottejmc commented 6 months ago

Hi @c-goldberg,

I've had a preliminary look through the various archives for potential avatar thumbnails that match the lesson theme. How do you feel about these options? (We would crop out any parts of text.)

Just suggestions! Please do let me know if you find an image you'd prefer using.