programminghistorian / ph-submissions

The repository and website hosting the peer review process for new Programming Historian lessons
http://programminghistorian.github.io/ph-submissions
135 stars 112 forks source link

Designing a Timeline for the Tabletop and Tabletop Simulator #553

Closed RolRodr closed 3 months ago

RolRodr commented 1 year ago

The Programming Historian has received the following tutorial on 'Designing a Timeline for the Tabletop and Tabletop Simulator' by @copystar. This lesson is now under review and can be read at:

http://programminghistorian.github.io/ph-submissions/en/drafts/originals/designing-a-timeline-tabletop-simulator

Please feel free to use the line numbers provided on the preview if that helps with anchoring your comments, although you can structure your review as you see fit.

I will act as editor for the review process. My role is to solicit two reviews from the community and to manage the discussions, which should be held here on this forum. I have already read through the lesson and provided feedback, to which the author has responded.

Members of the wider community are also invited to offer constructive feedback which should post to this message thread, but they are asked to first read our Reviewer Guidelines (http://programminghistorian.org/reviewer-guidelines) and to adhere to our anti-harassment policy (below). We ask that all reviews stop after the second formal review has been submitted so that the author can focus on any revisions. I will make an announcement on this thread when that has occurred.

I will endeavor to keep the conversation open here on Github. If anyone feels the need to discuss anything privately, you are welcome to email me.

Our dedicated Ombudsperson is (Ian Milligan - http://programminghistorian.org/en/project-team). Please feel free to contact him at any time if you have concerns that you would like addressed by an impartial observer. Contacting the ombudsperson will have no impact on the outcome of any peer review.

Anti-Harassment Policy

This is a statement of the Programming Historian's principles and sets expectations for the tone and style of all correspondence between reviewers, authors, editors, and contributors to our public forums.

The Programming Historian is dedicated to providing an open scholarly environment that offers community participants the freedom to thoroughly scrutinize ideas, to ask questions, make suggestions, or to requests for clarification, but also provides a harassment-free space for all contributors to the project, regardless of gender, gender identity and expression, sexual orientation, disability, physical appearance, body size, race, age or religion, or technical experience. We do not tolerate harassment or ad hominem attacks of community participants in any form. Participants violating these rules may be expelled from the community at the discretion of the editorial board. Thank you for helping us to create a safe space.

anisa-hawes commented 1 year ago

Dear Mita @copystar and @RolRodr,

Lesson materials for this submission are now uploaded, and can be found in the following locations:

An initial Preview of this lesson is now available: http://programminghistorian.github.io/ph-submissions/en/drafts/originals/designing-a-timeline-tabletop-simulator

Please note that captions and descriptive alt-text will be required for all figure images. If you would like to email me this information @copystar, I'd be very happy to add these in on your behalf.

anisa-hawes commented 1 year ago

Thank you for providing captions and descriptive alt-text, Mita @copystar. I have added these to the .md file.

ludicpress commented 1 year ago

As someone who uses game design approaches for assignments in my courses, this can potentially be a valuable addition to the growing resources around game design as a pedagogical approach to learning. I have primarily focused on print 'n play board and card games (which Nandeck falls into), interactive fiction with Twine and Inkle, and digital role-playing games in Unity for my instruction. This is certainly a resource that I could potentially use as an option for student assignments.

The constructive feedback I have below is intended to help focus and build upon the work the author has already put together. My main overarching feedback though is: why should someone use Nandeck and Tabletop Simulator versus other available print n' play and simulator tools? And why limit game design to the Timeline mechanic? I think it would benefit the lesson plan if there was more context around print n' play game design and some other examples of tabletop games made with these tools. It also seems like Nandeck is maintained by one person. What will happen if they decide to stop supporting it in a few years? How useful will this lesson plan be at that point? This is why I think it's important you consider adding in additional options for both the tools and game design aspects. Your audience are instructors, like myself, who are looking for options that they can easily teach their students to use, but also robust enough to allow different kinds of tabletop game design. We all know tools come and go, but what principles and learning outcomes should folks takeaway from your lesson plan.

More specific feedback by paragraph:

hawc2 commented 11 months ago

@RolRodr if you're still looking for another reviewer, I sent you an email with another potential person you can ask

RolRodr commented 10 months ago

Thank you so much for your review, @ludicpress. Your review was thorough and thoughtful as we consider how to prepare lessons which can be adopted and adapted by other instructors. We're waiting for a confirmation for the second reviewer, which I will introduce upon confirmation.

adamlporter commented 10 months ago

Where I'm coming from: I've played a wide variety of card games (poker, spades, hearts, blackjack, etc., Magic the Gathering, Dominion (years ago), Flux, etc.). At my small, liberal arts college, I use role-playing games, both complex games like Reacting to the Past games and also simpler role-playing type games that put students into teams to work together on creating position papers and then enact some event in their team's roles. I have not used cards as described in this lesson, but I really like the idea.

Overall, I really like this lesson and think that it has a lot of potential. I appreciate the discussion of how to produce the cards and how to solve problems like putting the date on one side and not the other.

I think it might be helpful to describe other ways to incorporate card games into a classroom. There are a lot of card games that require thinking about probability and statistics (like poker) or require some basic math skills (blackjack); others are really complex (Magic the Gathering, Pokemon, Dominion); others have strategy but a lot of luck (Flux).

It seems to me that better games for classrooms would have a simple mechanism (MTG is over the top!) like the Timeline game described. Perhaps I'm not thinking broadly enough? Some discussion of this issue would be welcome.

It would also be helpful, perhaps, to have examples of other games with simple mechanisms to get instructors thinking about what might be possible. I thought of Trivia Pursuit and Pictionary. Are there other examples that could be provided to help instructors image how to use cards in the classroom?

I agree that it would be helpful to discuss alternatives to nanDECK, in case it goes out of business, stops development, etc. On the other hand, much of the lesson focuses on how to use nanDECK; it doesn't seem reasonable to expect this level of detail for several other software packages. I'm not sure how to balance these two requests.

Many of the articles I have read on PH (although I have read only a fraction of the total!) walk users through how to use software, techniques, etc. Currently, this article seems to straddle (a) explaining how ND works generally and (b) walking the user through a specific example.

I downloaded and installed nanDECK (it would be nice to have a live links to the various sites in parags 27-30; this may be planned for the final version of the lesson). I created a quick-and-dirty Excel file with four rows using images I got from Wikipedia. But following the lesson, I was unable to get a deck created. Some specific errors that I encountered:

I realize that a lot of these questions could be resolved by reading ND's documentation. But that's leads me to my general question: "What is this lesson supposed to do?" If it is a demonstration / walk-thru of ND, it would be helpful to have sample data (along with some instructions on where to install the sample data, the file structure needed, etc.) and more explicit step-by-step instructions. I shouldn't need to go to ND's manual/documentation to complete a demonstration / walk-thru. But this may not be the goal of the lesson: ND has a tutorial (which I haven't done) and perhaps the lesson should tell readers to go thru the tutorial and then return to the lesson. Why duplicate work that ND has done already?

On the other hand, having all of this contained in the lesson would make it easier for readers to work through the lesson and decide if ND is a tool they want to pursue using. So personally, I would recommend revising this lesson to include a more hands-on, walk-through approach, including providing sample data and instructions on how to install it. Doing so would also make it easier to give to students, should instructors want to have students make cards as a classroom activity.

At my college, we use Google docs a lot. I could see cards in the classroom where students might collaborate to create cards; they would do this by collaborating in Google Sheets to create the input file. The lesson notes this is possible (parag 62) and advises reading the ND manual. A link to the page in the manual would be helpful. This could also be expanded a bit in the lesson text with some evaluation of the process: how hard is this to set up? How well does it work? Is it easier just to download the Google sheet as an Excel file and load it into ND?

I think the discussion of TTS should be expanded. The author notes that she doesn't have a good use case for the TTS, nor do I. But for faculty who are teaching online courses, TTS might be quite useful. I don't think PH has any articles that discuss TTS -- searching for "Table top" in the PH interface resulted in zero hits. So explaining how TTS works more fulsomely (or providing links to YouTube videos that show it in action or other resources) would be useful for PH readers generally. Given the level of detail for using nanDECK, the two or three paragraphs about TTS seems brief.

hawc2 commented 9 months ago

@RolRodr can you summarize the review feedback here, give any additional advice to the author, and then give the author the go-ahead to start revising this lesson?

It sounds like there are some substantial revisions for the author to resolve regarding how this lesson replicates material on the NanDeck documentation, and I agree with @adamlporter that it makes sense this lesson defer to ND documentation for some granular steps (which might change in the future), and focus more on providing a walk through of using this tool with specific data for answering a specific research question. Both reviewers feedback seem to invite some concrete changes that make sense to me.

If @copystar can address these changes this fall, I'm optimistic we can publish this lesson this winter. Let me know how I can be of help in the meantime, and feel free to also email me at english@programminghistorian.org if you need assistance or have questions.

RolRodr commented 8 months ago

I apologize for my delay in pushing this process along.

Thank you so much @ludicpress and @adamlporter for your helpful reviews of this lesson.

Summarizing from both reviews and looking over the lesson again, here are some general points of revision:

Apart from the general revisions that should be done, below are some more discrete areas of editing from both reviews and some additional ones from me:

@copystar, you are good to start revising the tutorial with these revisions in mind. If there are any questions that arise or we can help with any of these revisions, please don't hesitate to reach out to myself, @hawc2 , or @anisa-hawes

hawc2 commented 7 months ago

Thanks @RolRodr for these final review comments. @copystar, will you be able to make these revisions in the coming weeks?

copystar commented 7 months ago

Hello @hawc2 - Yes, I've set aside some time over the next two weeks to make these revisions. Thank you! Mita

anisa-hawes commented 7 months ago

Hello Mita @copystar,

I hope you're well. Thank you for sharing your revisions with us. I've applied them on your behalf: https://github.com/programminghistorian/ph-submissions/commit/9f54adf8f1400f5dbc094af75a33121cc3d82954 and I've replaced Figures 2 and 5 with the updated files you sent me: https://github.com/programminghistorian/ph-submissions/commit/ae6290d44573dd79ec83f9d5311f3598a94533d1.

I've also made some small additions to the YAML and adjusted the link syntax throughout this lesson: https://github.com/programminghistorian/ph-submissions/commit/2341d36775399cab935010aeeeafa249bb3c5f84. Our preference is to embed URLs within running prose (rather than to show them in full) to support reader experience. In the next Phase of our workflow, our publishing team will generate archival versions of any external URLs featured in the lesson (except those which represent a direct activity, for example to download software or install a package). This helps to ensure the sustainability of this lesson as a learning resource.

I wanted to ask you about the sample Google Drive link you provide. Is this a sample path? Or does it represent an example document for readers work with? If it is an example document, then we can consider it an "asset" that is part of the lesson. In this case, it will be important for us to host this within our PH infrastructure so that we can sustain it.

Thank you. Anisa

copystar commented 7 months ago

Hello Anisa,

Thank you so much for applying these revisions for me.

The Google Drive is a directory of files that the reader can download and work with: https://drive.google.com/drive/folders/1kkGOz3QHGSTj0ca4HlOEl1eIgX2NN0c6

If it is preferred to have these files hosted on PH, I would be happy to have them hosted on the Github. I'm just not sure how I would do that.

Please let me know me know how I can help or if there is anything you are waiting on me to do!

Thank you, Mita

On Thu, Dec 7, 2023 at 4:14 PM Anisa Hawes @.***> wrote:

Hello Mita @copystar https://github.com/copystar,

I hope you're well. Thank you for sharing your revisions with us. I've applied them on your behalf: 9f54adf https://github.com/programminghistorian/ph-submissions/commit/9f54adf8f1400f5dbc094af75a33121cc3d82954 and I've replaced Figures 2 and 5 with the updated files you sent me: ae6290d https://github.com/programminghistorian/ph-submissions/commit/ae6290d44573dd79ec83f9d5311f3598a94533d1 .

I've also made some small additions to the YAML and adjusted the link syntax throughout this lesson: 2341d36 https://github.com/programminghistorian/ph-submissions/commit/2341d36775399cab935010aeeeafa249bb3c5f84. Our preference is to embed URLs within running prose (rather than to show them in full) to support reader experience. In the next Phase of our workflow, our publishing team will generate archival versions of any external URLs featured in the lesson (except those which represent a direct activity, for example to download software or install a package). This helps to ensure the sustainability of this lesson as a learning resource.

I wanted to ask you about the sample Google Drive link you provide. Is this a sample path? Or does it represent an example document for readers work with? If it is an example document, then we can consider it an "asset" that is part of the lesson. In this case, it will be important for us to host this within our PH infrastructure so that we can sustain it.

Thank you. Anisa

— Reply to this email directly, view it on GitHub https://github.com/programminghistorian/ph-submissions/issues/553#issuecomment-1846122685, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGWWSTZGNIE64HZARDFE43YIIWUVAVCNFSM6AAAAAAWISB77WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBWGEZDENRYGU . You are receiving this because you were mentioned.Message ID: @.***>

--

Mita Williams newsletter: https://uofwinds.com/ more info: https://aedileworks.com/about/

anisa-hawes commented 7 months ago

Ah! Thank you for clarifying, Mita @copystar.

As these are example files for readers to work with, we'd like to host these within our /assets directory.

Is it everything in that folder? Or specific files within it? If it is specific files only, please comment here / or email me a file list. We're happy to take care of processing the download + upload for you, and we'll replace any links in the lesson which point to the Google Drive with new links to the hosted assets.

copystar commented 7 months ago

Hello Anisa

Happy to answer! Please host everything in the folder. There should be https://drive.google.com/drive/folders/1cXNyla3THA8cYNZKGLXeh7_5ctK8xOYX

Thank you! Mita

On Thu, Dec 7, 2023 at 4:40 PM Anisa Hawes @.***> wrote:

Ah! Thank you for clarifying, Mita.

As these are example files for readers to work with, we'd like to host these within our /assets https://github.com/programminghistorian/ph-submissions/tree/gh-pages/assets directory.

Is it everything in that folder? Or specific files within it? If it is specific files only, please comment here / or email me a file list. We're happy to take care of processing the download + upload for you, and we'll replace any links in the lesson which point to the Google Drive with new links to the hosted assets.

— Reply to this email directly, view it on GitHub https://github.com/programminghistorian/ph-submissions/issues/553#issuecomment-1846153359, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGWWSTAV4VHESJFWA2D4NDYIIZWJAVCNFSM6AAAAAAWISB77WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBWGE2TGMZVHE . You are receiving this because you were mentioned.Message ID: @.***>

--

Mita Williams newsletter: https://uofwinds.com/ more info: https://aedileworks.com/about/

charlottejmc commented 7 months ago

Hello Mita (@copystar),

I have made some changes to the section ## Build Your Own Timeline so that we redirect our readers to the folder /assets/designing-a-timeline-tabletop-simulator instead of the Google Drive.

I have also turned all the filenames in your explanatory list into links to individual files, so readers can download them separately if they wish.

anisa-hawes commented 7 months ago

Thank you, @charlottejmc – These adjustments are very clear.


Hello again Mita @copystar,

There are a few other elements which it would be useful to clarify:

Are you intending to make further revisions to the lesson from here?

Thank you for collaborating with these adjustments!

anisa-hawes commented 6 months ago

Hello Mita @copystar.

Thank you for your email which clarifies that:

If you and @RolRodr are in agreement that you've completed the revisions, I can hand it over to Alex @hawc2 for a thorough read-through before approving its move into the copyediting phase where we will draw out any final remaining queries.

I'd be grateful for your help us with the questions above.

Very best, Anisa

copystar commented 6 months ago

Hello Anisa

You mention that the text within this grey box is a direct quote of the

NanDECK manual. If so, I think we will need to create an endnote here so that this is cited specifically. (At the moment, you include the manual in your general References list). Question: Are there any other points in the lesson where you quote the manual directly?

If the reference that I provide in Para 62 is not sufficient (" It is also possible to LINK to a Google Sheets spreadsheet. The additional steps necessary are outlined within the nanDECK Manual under the section for LINK and are reproduced here (Nini):"), then I'm happy to create an additional endnote. From a copyediting point of view, where should that be?

In this case, it will be important to remove and replace the references to

the Windsor-Timeline.xlsx throughout the lesson and the figures so that readers are not confused. Question: Are you able to advise which .xlsx files of those now hosted in our /assets/designing-a-timeline-tabletop-simulator https://github.com/programminghistorian/ph-submissions/tree/gh-pages/assets/designing-a-timeline-tabletop-simulator directory are the relevant ones here?

Oh, thanks for catching this. In my edits, I had forgotten to return to this passage to include these assets. I've added an example asset called Windsor-Timeline.xlsx and five sample images to this directory: https://drive.google.com/drive/folders/1dSJFH31sNlceNZJCrPDwQMpQNp03F1Tk?usp=sharing

Could these be added to the assets directory for hosting?

Paragraph 70 needs to be replaced with this:

This lesson provides a small sample Excel spreadsheet (Windsor-Timeline.xlsx) and five images depicting five historical events for the city of Windsor, Ontario, Canada that can be used to generate an example deck of five cards.

Scanning through the text with this question in mind, I noticed that the

caption for Figure 3 seems to be incorrect. It reads: An example of a page of cards generated by nanDECK with requested black borders between cards and dotted lines to make cutting easier but it depicts a data table with columns headed Year, Fact, Images. Are you able to check these through and let me know what the correct caption should read here?

Yes, thanks for catching this! I've also attached an alternative Figure 3. The replacement caption should read, Windsor-Timeline.xlsx is a spreadsheet with 3 columns, Year, Fact and Images.

I believe that this would complete all the requested revisions at this point,

Thank you Mita

On Wed, Dec 13, 2023 at 2:01 PM Anisa Hawes @.***> wrote:

Hello Mita @copystar https://github.com/copystar.

Thank you for your email which clarifies that:

  • At paragraph 65 of the Preview (inside the grey box), you are referencing a sample Google Share link. I think it would help readers if it was more clearly a sample rather than a live link. I've adjusted it to https://docs.google.com/spreadsheets/d/SAMPLE_ID/edit?usp=sharing 2407cea https://github.com/programminghistorian/ph-submissions/commit/2407cea8636728ea17c822d3db6b0b6f5786fd21 at paragraph 65, and also in the following paragraphs 66 and 67 of the Preview. After copyediting, my team will also typeset this lesson which I think will help us to clarify things further.

  • You mention that the text within this grey box is a direct quote of the NanDECK manual. If so, I think we will need to create an endnote here so that this is cited specifically. (At the moment, you include the manual in your general References list). Question: Are there any other points in the lesson where you quote the manual directly?

  • At paragraph 70 of the Preview, you mentioned a 'small sample Excel spreadsheet (Windsor-Timeline-Spreadsheet-Example.xlsx)' but we noticed that this wasn't included in the Google Drive folder. You explain in your email that you decided to use different sample images in the end, which are available for reuse under open licenses.

  • In this case, it will be important to remove and replace the references to the Windsor-Timeline.xlsx throughout the lesson and the figures so that readers are not confused. Question: Are you able to advise which .xlsx files of those now hosted in our /assets/designing-a-timeline-tabletop-simulator https://github.com/programminghistorian/ph-submissions/tree/gh-pages/assets/designing-a-timeline-tabletop-simulator directory are the relevant ones here?

  • Scanning through the text with this question in mind, I noticed that the caption for Figure 3 seems to be incorrect. It reads: An example of a page of cards generated by nanDECK with requested black borders between cards and dotted lines to make cutting easier but it depicts a data table with columns headed Year, Fact, Images. Are you able to check these through and let me know what the correct caption should read here?

If you and @RolRodr https://github.com/RolRodr are in agreement that you've completed the revisions, I can organise for this lesson to move into the copyediting phase where we will draw out any remaining queries.

I'd be grateful for your help us with the questions above.

Very best, Anisa

— Reply to this email directly, view it on GitHub https://github.com/programminghistorian/ph-submissions/issues/553#issuecomment-1854543919, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGWWSTJVMNCJA7GCZNS5O3YJH3RVAVCNFSM6AAAAAAWISB77WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJUGU2DGOJRHE . You are receiving this because you were mentioned.Message ID: @.***>

--

Mita Williams newsletter: https://uofwinds.com/ more info: https://aedileworks.com/about/

anisa-hawes commented 6 months ago

Thank you for these detailed answers, Mita @copystar. Charlotte and I will work through the adjustments today 🙂

charlottejmc commented 6 months ago

Hello @copystar,

Thank you for your help. I've had a look at these adjustments today.

Thanks again,

Charlotte

copystar commented 6 months ago

Thanks for the update.

I've added a copy of Figure 3 to my Drive for download: https://drive.google.com/file/d/1ilErsVLEmSabf3q0Yaqb9iiY9VZSU1mz/view?usp=sharing And I understand if the image is considered superfluous.

When checking the new table against our current Figure 3, I noticed that it

seems like rows 7-11 are a duplicate of 2-6, without the Year. Can you confirm that this is how the table should look?

Yes, this is correct. I explain why this is so in para 91. For clarity, we could re-caption figure 3 to read 'Rows 2-6 generate the card faces and rows 7-11 generate the card backs.

Thank you! Mita

On Thu, Dec 14, 2023 at 9:58 AM charlottejmc @.***> wrote:

Hello @copystar https://github.com/copystar,

Thank you for your help. I've had a look at these adjustments today.

  • Paragraph 62: I see you have indeed referenced the NanDeck manual using an author-date referencing system (Nini). We use the Chicago Manual of Style 17th edition https://www.chicagomanualofstyle.org/tools_citationguide/citation-guide-1.html's endnote system in our lessons, so I will update all references throughout the lesson. I will do this during the typesetting phase https://github.com/programminghistorian/ph-submissions/wiki/Phase-6-Sustainability-Accessibility of our publication workflow.
  • Paragraph 70: I have made this replacement and changed the wording slightly so I could link the Windsor-Timeline-Example files, which I have now uploaded to our assets directory.
  • Figure 3: I have updated the caption with the sentence you suggest. However, because your email is in essence a reply on GitHub, it hasn't sent over the alternative image you attached. Am I correct in assuming it would be a screenshot of the new Windsor-Timeline.xlsx table? I won't make the change just yet, though, because we might determine in the following phases that this image is slightly superfluous (our commitment to sustainability and accessibility drives our desire to minimise the number of large files like images in our lessons).
  • Windsor-Timeline.xlsx: when checking the new table against our current Figure 3, I noticed that it seems like rows 7-11 are a duplicate of 2-6, without the Year. Can you confirm that this is how the table should look?

Thanks again,

Charlotte

— Reply to this email directly, view it on GitHub https://github.com/programminghistorian/ph-submissions/issues/553#issuecomment-1856005621, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGWWSUY2SYOTLC6AMAKJU3YJMHZTAVCNFSM6AAAAAAWISB77WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJWGAYDKNRSGE . You are receiving this because you were mentioned.Message ID: @.***>

--

Mita Williams newsletter: https://uofwinds.com/ more info: https://aedileworks.com/about/

anisa-hawes commented 6 months ago

Thank you, Mita @copystar!

We've updated the caption for Figure 3 https://github.com/programminghistorian/ph-submissions/commit/dedb98e314c5364c72b4ada3ef84fcf696acbdce, and replaced the image for now https://github.com/programminghistorian/ph-submissions/commit/01dd11288e211258941070c94693dc993dc143b7 (to decide later if a Markdown-formatted data table would be a suitable substitute).

--

Hello @hawc2,

Over to you. You will note that there remain a couple of queries which Charlotte and I outline in our comments above, but my sense is that it would be most efficient to tackle these following your read-through.

A.

hawc2 commented 6 months ago

Hi @copystar, thanks for this interesting lesson, I’m excited to add this contribution to ProgHist’s repertoire, as it really expands our range into some new spheres. I’ve done a thorough read through and line edit, mostly simplifying some of the language and clarifying some sentences. Those changes can be viewed in the online preview here: https://programminghistorian.github.io/ph-submissions/en/drafts/originals/designing-a-timeline-tabletop-simulator

I have additional comments I’m itemizing below for you to take into consideration as you make a final round of revisions before copyedits. Before I get into my feedback, though, I wanted to highlight remarks made by @adamlporter during his review, as I think your revisions haven’t fully addressed those concerns. Please read carefully Adam’s comments from “I realize that alot” to the paragraph about “I think the discussion of TTS should be expanded.” I think most of my comments below are going to help flesh out the changes Adam requested there.

One you've addressed these additional revisions, we'll be ready to go into copyediting. Thanks for all your work getting this into shape. I understand it's not the best time of the year to do work like this, so no worries if you need to hold off on revisions until early January. We're not in a huge rush to publish this piece, so let's take the time to make it the best it can be.

hawc2 commented 5 months ago

@copystar Will you be able to complete revisions soon? We'd like to move this forward to publish in coming month.

copystar commented 5 months ago

Hello Alex, Yes, I will get the revisions to you shortly, hopefully during the week. Thank you, Mita

On Fri, Jan 19, 2024 at 2:22 PM Alex Wermer-Colan @.***> wrote:

@copystar https://github.com/copystar Will you be able to complete revisions soon? We'd like to move this forward to publish in coming month.

— Reply to this email directly, view it on GitHub https://github.com/programminghistorian/ph-submissions/issues/553#issuecomment-1900979366, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGWWSVA3GSYILBIVGZAXNDYPLBYRAVCNFSM6AAAAAAWISB77WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBQHE3TSMZWGY . You are receiving this because you were mentioned.Message ID: @.***>

--

Mita Williams newsletter: https://uofwinds.com/ more info: https://aedileworks.com/about/

charlottejmc commented 5 months ago

Hello @copystar,

I have uploaded your edits to the /drafts/originals/designing-a-timeline-tabletop-simulator.md markdown file. You can see the 'rich diff' of the changes you made in this commit.

Just one thing: I believe some steps might still be referring to files inside the Windsor Timeline Example folder, although I can see you have removed the links to it. Could you confirm that we can still delete the folder from the lesson's /assets?

Thank you!

anisa-hawes commented 5 months ago

Thank you, @charlottejmc!

--

Hello @hawc2.

Mita @copystar's revisions are now available for you to re-read in our Preview.

hawc2 commented 5 months ago

Thanks @copystar for your edits. These mostly addressed my concerns.

It's possible during copyediting, we may address further some of the issues I raised, including the way datasets are labeled and shared. I may also have additional small changes to request after copyediting is complete.

Note I've made a few line edits to this current version, including to make sure code blocks are prefaced by commentary.

@anisa-hawes this lesson is ready for copyediting!

anisa-hawes commented 5 months ago

Thank you, @hawc2!

--

Hello Mita @copystar,

Your lesson will now be copyedited by our Publishing Assistant, Charlotte (@charlottejmc). We aim to complete the work within ~21 days by 28th February.

Please note that you won't have direct access to make further edits to your files during this Phase.

Any further revisions can be discussed with your editor @RolRodr and agreed with Alex @hawc2 after copyedits are complete. Thank you for your understanding.

Anisa.

copystar commented 5 months ago

Thank you all. I'm happy to continue working through necessary edits, through @RolRodr and @hawc2 as necessary. Mita

charlottejmc commented 4 months ago

Hello @copystar and @RolRodr, I've prepared a PR with the copyedits for your review.

There, you'll be able to review the 'rich-diff' to see my edits in detail. You'll also find brief instructions for how to reply to my questions and comments, which I've tied to specific lines of the file. I've also left a separate comment with a couple further questions for us to look at.

When you're both happy, we can merge in the PR.

charlottejmc commented 4 months ago

Hi @copystar, @RolRodr and @hawc2,

I thought I would provide an overview of the final outstanding points which Mita and I are discussing in the Pull Request before we merge our edits.

When we're all happy that these points have been addressed and resolved, we can merge in the PR.

charlottejmc commented 4 months ago

Hello @hawc2,

We're making progress through this lesson's sustainability + accessibility checks:

http://programminghistorian.github.io/ph-submissions/en/drafts/originals/designing-a-timeline-tabletop-simulator

Publisher's sustainability + accessibility actions:

Authorial / editorial input to YAML: Hello @RolRodr and @hawc2, Could you help with the following?

The image must be:

- name: Mita Williams
  orcid: 0000-0001-7816-6965
  team: false
  bio:
    en: |
      Mita Williams is the Acting Law Librarian at the Don & Gail Rodzik Law Library, University of Windsor, Ontario, Canada.

Files we're preparing for transfer to Jekyll:

Promotion:

anisa-hawes commented 3 months ago

Hello @hawc2 ,

This lesson's sustainability + accessibility checks are now complete, so it is ready for your final review.

Promotion:

Thank you.

hawc2 commented 3 months ago

@anisa-hawes I can take a closer look later, but from a brief skim it looks mostly ready to go.

Two minor issues with images: 1) Figure 9 isn't rendering. 2) Some images seem slightly blurry? I don't know if it's just me and the computer I'm on, but the screenshot of the spreadsheet looks kind of blurry or grainy to me here and the text is not the easiest to read on most images: https://programminghistorian.github.io/ph-submissions/images/designing-a-timeline-tabletop-simulator/en-or-designing-a-timeline-tabletop-simulator-03.png

anisa-hawes commented 3 months ago

Thank you, @hawc2. Apologies for the oversight - a small correction was needed in the image filenames. All figures are rendering now.

In terms of the 'blurriness', I would agree that the images which depict the nanDECK interface (Figures 1, 2 and 5) are not sharp. These have been resized according to our conventions, but actually looking back the original images we received were already somewhat blurry. You can see figures 2 and 5 as received here: https://github.com/programminghistorian/ph-submissions/commit/ae6290d44573dd79ec83f9d5311f3598a94533d1 and Figure 1 here: https://github.com/programminghistorian/ph-submissions/commit/ef6ea6da52778dd04e366f6a4881a166aa7b4e17 (Note: the images numbered 2 and 5 uploaded in this initial commit were later replaced).

My suggestion to improve Figures 3 and 7 (which display Excel spreadsheets) is to create tables in raw Markdown. This would also improve accessibility to this resource. If you agree, Charlotte and I can take care of transforming those two.

hawc2 commented 3 months ago

That sounds fine to me, whatever you think is best here is fine by me.

On Wed, 13 Mar 2024 at 12:25, Anisa Hawes @.***> wrote:

Thank you, @hawc2 https://github.com/hawc2. Apologies for the oversight

  • a small correction was needed in the image filenames. All figures are rendering now.

In terms of the 'blurriness', I would agree that the images which depict the nanDECK interface (Figures 1, 2 and 5) are not sharp. These have been resized according to our conventions, but actually looking back the original images we received were already somewhat blurry. You can see figures 2 and 5 as received here: ae6290d https://github.com/programminghistorian/ph-submissions/commit/ae6290d44573dd79ec83f9d5311f3598a94533d1 and Figure 1 here: ef6ea6d https://github.com/programminghistorian/ph-submissions/commit/ef6ea6da52778dd04e366f6a4881a166aa7b4e17 (Note: the images numbered 2 and 5 uploaded in this initial commit were later replaced).

My suggestion to improve Figures 3 and 7 (which display Excel spreadsheets) is to create tables in raw Markdown. This would also improve accessibility to this resource. If you agree, Charlotte and I can take care of transforming those two.

— Reply to this email directly, view it on GitHub https://github.com/programminghistorian/ph-submissions/issues/553#issuecomment-1994874298, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXF4EGI3C4SFLRIA3XO4JDYYB4XHAVCNFSM6AAAAAAWISB77WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJUHA3TIMRZHA . You are receiving this because you were mentioned.Message ID: @.***>

charlottejmc commented 3 months ago

Hi @hawc2 and @copystar,

I've replaced figures 3 and 7 with markdown tables, and renumbered the remaining figures to stay consistent.

anisa-hawes commented 3 months ago

Thank you, @charlottejmc !

--

Hello @hawc2,

My view is that the spreadsheets as Markdown tables are a positive improvement. We've made the necessary slight adjustments to the surrounding sentences which clarify that what is provided in the tables represent what would be in a readers' Excel spreadsheet.

I don't think there is a great deal we can do about the blurriness of the figures depicting the nanDECK interface (now Figure numbers 1, 2, and 4) unless Mita @copystar is able to re-supply them as higher resolution screenshots if she would like to?

hawc2 commented 3 months ago

@copystar could you take fresh screenshots of the images included in this lesson? I've looked over the lesson and I think it's otherwise ready to move forward.

But if you look at most of the screenshots, you'll see they could definitely be clearer, and in their current state, they detract from the lesson's quality for sure. For example, this image is tough to look at, especially if you zoom in: https://programminghistorian.github.io/ph-submissions/images/designing-a-timeline-tabletop-simulator/en-or-designing-a-timeline-tabletop-simulator-02.png

Once we update the screenshots, we can move this forward to publication @anisa-hawes.

copystar commented 3 months ago

Is this better? I've tried another method to screen capture.

Timeline-Screenshot-as-png

charlottejmc commented 3 months ago

Thank you @copystar, Anisa and I both think that looks better.

Could you please send new screenshots of figures 1, 2 and 4 to my email address, publishing.assistant[@]programminghistorian.org?

If it's not too much trouble, you could also send me new screenshots of figures 3 and 6, but I think their legibility is perhaps less essential.

charlottejmc commented 3 months ago

@copystar, thank you for sending me the new images by email. I've replaced them, and they look great in the preview!

This lesson is now definitely ready for publication 🎉

anisa-hawes commented 3 months ago

Designing a Deck of Timeline Cards for Tabletops and Tabletop Simulator is published!

Congratulations @copystar! Thank you all for your contributions


Our suggested citation for this lesson is:

Mita Williams, "Designing a Deck of Timeline Cards for Tabletops and Tabletop Simulator," Programming Historian 13 (2024), https://doi.org/10.46430/phen0118.

We appreciate your help to circulate our social media announcements about this lesson among your networks: Twitter/X: https://twitter.com/ProgHist/status/1770199437354168371 Mastodon: https://hcommons.social/@proghist/112124454789294087


Sincere thanks.