search

programminghistorian / ph-submissions

The repository and website hosting the peer review process for new Programming Historian lessons
http://programminghistorian.github.io/ph-submissions
139 stars 114 forks source link

Copyedit concevoir recherche donnees nodegoat #597

Closed charlottejmc closed 9 months ago

charlottejmc commented 10 months ago

I am preparing to merge my copyedits of the FR lesson #459 concevoir-recherche-donnees-nodegoat.

charlottejmc commented 10 months ago

Hello @digitalkosovski and @spapastamkou.

I've now prepared the copyedits for this lesson. I'd be grateful if you could review the adjustments and confirm that you are happy for me to merge these. You can see the details of my edits under the files changed tab!

I'd like to bring your attention to the comments I have attached to certain specific lines. You can respond to any of my suggestions via the comments below, or click Resolve conversation if you're happy with them like this:

image

If you want to make edits, please work by navigating to the files changed and clicking the three dots at the upper right of the file, then Edit file:

image
spapastamkou commented 9 months ago

(@charlottejmc tu verras les mêmes commentaires à deux reprises, désolée:))

charlottejmc commented 9 months ago

Merci beaucoup @spapastamkou pour tes commentaires vraiment détaillés et réfléchis ! J'apprécie ton expertise en HN qui a pu faire ressortir les quelques erreurs que j'avais introduites 😬 J'ai laissé deux commentaires à propos des titres, mais je crois qu'on arrive bientôt à bout !

anisa-hawes commented 9 months ago

Thank you @charlottejmc, @digitalkosovski and @spapastamkou.

I think I agree with Charlotte about the title. In my view, effective lesson titles often start with an active verb. The key thing is discoverability (both through online search towards our website, and within our lesson directories). I would like to suggest that a combination of two of Charlotte's proposed alternative titles might be worth consideration:

Transformer ses sources en données : la conceptualisation d'une base de données en sciences humaines avec nodegoat

or

Transformer ses sources en données : la conceptualisation d'une base de données avec nodegoat

Translating your conversations above, I understand you are also in discussion about the section and sub-section structure. This aspect will (of course) have an impact upon readers' initial encounter with this lesson, because the table of contents is one of the first things they will read. If the table of contents is clear, easy-to-follow, and defines meaningful signposts through the lesson it can be an important navigation tool.

I am sure @marie-flesch will want to take a view on both the title + the section structure, and make the final decision when she does her thorough read-through pre-Publication.

But for now, I think this PR can be merged. Charlotte and I will move onwards to typesetting and creation of archival links, before handing over to Marie with the questions raised above.

Thanks to all. Anisa

spapastamkou commented 9 months ago

@anisa-hawes Thank you for your thoughts. I just commented for the title; as for the subsections suggestion, these have been validated by the author; my question was about the level - I did not know we had level 4 accepted now. I believe all the pending questions have been resolved and the lesson should be ready after Charlotte's final work and Marie's final editorial controls. Thanks all for your work.