Copyedit designing a timeline tabletop simulator

[charlottejmc]

I am preparing to merge my copyedits of designing-a-timeline-tabletop-simulator, represented by Issue #553

[charlottejmc]

Hello @copystar and @RolRodr,

I've now prepared the copyedits for this lesson. I'd be grateful if you could review the adjustments and confirm that you are happy for me to merge these. You can see the details of my edits under the files changed tab!

I'd like to bring your attention to the comments I have attached to certain specific lines. You can respond to any of my suggestions via the comments below, or click Resolve conversation if you're happy with them like this:

If you want to make edits, please work by navigating to the files changed and clicking the three dots at the upper right of the file, then Edit file:

[charlottejmc]

Hi @copystar,

Just a couple extra things which I did not tie to any specific line in the text:

• [x] I've noticed you use both the term 'face' and 'front' of a card, in the text, in the section headings and in the code. Perhaps there is a reason for this? I wonder if it would be possible to only choose one, and apply it throughout.
• [x] I believe some steps might still be referring to files inside the Windsor Timeline Example folder, although I can see you have removed the links to it. Could you confirm that we can delete the folder from the lesson's /assets?

[copystar]

• [x] I agree it should be consistent : "face" would be the preferred term.
• [x] Yes, you can delete the folder of Windsor Timeline Example in /assets.
• [ ] I will review the text to see if there are any stray references to Windsor Timeline Example.
  Thank you!

[charlottejmc]

Hi @copystar, I've updated the file with the majority of your suggestions. Thank you very much for your replies so far!

The references to the Windsor-Timeline example appear at lines:

• 283, 289, 294 (Figure 3), when you showcase the use of the LINK directive
• 476, 497, 502, when you split the spreadsheet into 2 for Tabletop Simulator and generate two .png images

I understand that we don't need to link to anything in our /assets folder here, because you're simply using the filenames from your own Windsor Timeline deck as examples. I wonder if it might not make things a little clearer to add small phrases like 'in our example...', or 'the spreadsheet the author used was...', so the reader knows where these filenames come from. Let me know what you think and I'd be happy to add those in if you think it's useful!

In any case, I'll delete the Windsor Timeline Example folder from the assets.

I also thought that it would be helpful to create a new folder called For nanDECK which mirrors For Tabletop Simulator, in which I filed the Build-Your-Own-Timeline.xlsx, PH_nandeck_Your_Timeline.txt, Your-Timeline-Duplex-Printing-Result.pdf and 6 .png assets used in the nanDECK section of the lesson. I can edit Line 399 slightly to explain the new structure of the assets folder.

[copystar]

As I was re-reading the draft, I noticed the following

• [x] There is a premature paragraph break at the end of ¶5
• [x] "lession" in ¶8 should be "lesson"
• [x] also in ¶8, "a PDF" should read, "pngs"
• [x] ¶45: correction: a set of 59 cards (not 58)
• [x] is there a way to scale down the image of Figure 6: it looks very large to my eyes can probably could be scaled down by half

[copystar]

Hi @copystar, I've updated the file with the majority of your suggestions. Thank you very much for your replies so far!

The references to the Windsor-Timeline example appear at lines:

* 283, 289, 294 (Figure 3), when you showcase the use of the `LINK` directive

* 476, 497, 502, when you split the spreadsheet into 2 for Tabletop Simulator and generate two `.png` images

I understand that we don't need to link to anything in our /assets folder here, because you're simply using the filenames from your own Windsor Timeline deck as examples. I wonder if it might not make things a little clearer to add small phrases like 'in our example...', or 'the spreadsheet the author used was...', so the reader knows where these filenames come from. Let me know what you think and I'd be happy to add those in if you think it's useful!

In any case, I'll delete the Windsor Timeline Example folder from the assets.

I also thought that it would be helpful to create a new folder called For nanDECK which mirrors For Tabletop Simulator, in which I filed the Build-Your-Own-Timeline.xlsx, PH_nandeck_Your_Timeline.txt, Your-Timeline-Duplex-Printing-Result.pdf and 6 .png assets used in the nanDECK section of the lesson. I can edit Line 399 slightly to explain the new structure of the assets folder.

I think the suggestion to use phrasing like ' 'the spreadsheet the author used was..' will be useful, thank you. I also like the suggestion to mirror the folders so that they read similarly, "For..."

[charlottejmc]

As I was re-reading the draft, I noticed the following

• [x] There is a premature paragraph break at the end of ¶5
• [x] "lession" in ¶8 should be "lesson"
• [x] also in ¶8, "a PDF" should read, "pngs"
• [x] ¶45: correction: a set of 59 cards (not 58)
• [x] is there a way to scale down the image of Figure 6: it looks very large to my eyes can probably could be scaled down by half

Hi @copystar,

Thanks for these. I understand you were checking the the preview here. I'm sorry that I didn't make this clear, but the preview is generated from the draft which is currently on the main gh-pages branch. My copyedits won't reflect in the preview until I merge this branch! You can check the most up-to-date version of the copyedited draft by clicking on Files changed of this Pull Request and then en/drafts/originals > designing-a-timeline-tabletop-simulator.

• [ ] Issues 1, 2, and 3 you've flagged above have already been fixed in my edits.
• [ ] Thank you for noting this. I've actually now changed every instance of 58 to 59, and hope that's correct.
• [ ] Yes, the images are very big right now! Part of the typesetting process (which will come after I merge the copyedits) will involve sizing the images down to a consistent standard.
• [ ] I've also now made the changes you approved above (create a folder For nanDECK and using phrasing like 'the spreadsheet the author used was...'
• [ ] I've changed the title to your preferred version: "Designing a deck of Timeline cards for tabletops and Tabletop Simulator"

I'm happy to merge my edits at this stage, and move on to the typesetting phase. We'll still be able to make changes (if you find any further issues) during that phase.

[copystar]

Thank you!

[copystar]

Thank you for everyone who made this lesson available to the world!

I'm going to write a blog post (and make a special law-related game for it) shortly to help share this work more widely.

I did notice that the DOI doesn't seem to resolve yet. Can this be submitted so I can add this work to my ORCiD profile?

Thank you all again, Mita