search

programminghistorian / ph-submissions

The repository and website hosting the peer review process for new Programming Historian lessons
http://programminghistorian.github.io/ph-submissions
137 stars 111 forks source link

Visualização básica de dados tabulares com R #624

Open ericbrasiln opened 1 month ago

ericbrasiln commented 1 month ago

Programming Historian em português recebeu uma proposta de aula intitulada 'Visualização básica de dados tabulares com R' por @dianamsmpsantos.

Os objetivos de aprendizagem da aula proposta são:

Eu compartilhei esta proposta para feedback com a equipa portuguesa. Consideramos esta proposta com base nos seguintes critérios:

Estamos felizes em convidar @dianamsmpsantos a desenvolver esta proposta em uma submissão sob a orientação de editor indicado em breve.

O pacote de submissão deve incluir:

@dianamsmpsantos já compartilhou o pacote de submissão comigo. Nossa equipe de Publicação processará os novos materiais da aula em setembro e preparará uma prévia do rascunho inicial. Eles discutirão qualquer dúvida com o colaborador e postarão um comentário nesta questão para fornecer a localização de todos os arquivos-chave, bem como um link para a prévia, onde os colaboradores poderão ler a lição conforme o rascunho avança.

Nossos ombudspersons dedicados são Ian Milligan (inglês), Silvia Gutiérrez De la Torre (español), Hélène Huet (francês) e Luis Ferla (português). Sinta-se à vontade para contatá-los a qualquer momento se tiver preocupações que gostaria de tratar com um observador imparcial. Entrar em contato com os ombudspersons não terá impacto no resultado de qualquer revisão por pares.

anisa-hawes commented 2 weeks ago

Thank you, @ericbrasiln!

@charlottejmc and I will process these submission materials and set up the lesson preview for you this week ✨

charlottejmc commented 2 weeks ago

Olá @ericbrasiln e @dianamsmpsantos,

Pode encontrar os ficheiros principais aqui:

Pode consultar a pré-visualização da lição aqui:

Hello @dianamsmpsantos, my notes on this submission are pretty much the same as those I outlined in my comment on your other lesson, Investigar a literatura lusófona através dos tempos usando a Literateca:

dianamsmpsantos commented 1 week ago

Dear Charlotte I think I have changed everything according to your comments. However, I noticed that Figure 5 and Figura 6 do not show all x-labels, so I am going to send you new figures. I assume it is directly to you and not to this ticket. Thank you in advance Diana

charlottejmc @.***> escreveu (quinta, 5/09/2024 à(s) 09:47):

Olá @ericbrasiln https://github.com/ericbrasiln e @dianamsmpsantos https://github.com/dianamsmpsantos,

Pode encontrar os ficheiros principais aqui:

Pode consultar a pré-visualização da lição aqui:

- http://programminghistorian.github.io/ph-submissions/pt/esbocos/originais/visualizacao-basica-dados-tabulares-R

Hello @dianamsmpsantos https://github.com/dianamsmpsantos, my notes on this submission are pretty much the same as those I outlined in my comment https://github.com/programminghistorian/ph-submissions/issues/599#issuecomment-2330726031 on your other lesson, Investigar a literatura lusófona através dos tempos usando a Literateca:

  • The code is looking a little strange, for example at lines 112-114; 153-155; 159-162... Did you mean to separate the code individually line by line, or were you hoping for them to appear as code blocks instead? If you'd like them to appear as code blocks, I can make that change for you. In general, you might find it easier to read and write your code by simply using single backticks around short bits of code (in-line, or single lines of code).
  • I notice you have included an asset https://github.com/programminghistorian/ph-submissions/tree/gh-pages/assets/visualizacao-basica-dados-tabulares-R, but this file not is linked to directly from within the lesson (so that readers can access it). Would you be able to add the link in where relevant? You can point directly to the file on Github, for example like this: dadosPeriodLit.tsv.
  • Finally, I saw that you provided 'alt-text' for all images, thank you! Unfortunately, it is currently a little under-descriptive, so I'd like to ask whether you might be able to try adding some more information to them (please see my other comment for further details).

— Reply to this email directly, view it on GitHub https://github.com/programminghistorian/ph-submissions/issues/624#issuecomment-2330839062, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6H44WOGUPJZ7IBWH7NKQLZVAEAPAVCNFSM6AAAAABMHDMBEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZQHAZTSMBWGI . You are receiving this because you were mentioned.Message ID: @.***>

dianamsmpsantos commented 1 week ago

Figures sent, please let me know if anything else is needed Diana

Diana Santos @.***> escreveu (quarta, 11/09/2024 à(s) 12:06):

Dear Charlotte I think I have changed everything according to your comments. However, I noticed that Figure 5 and Figura 6 do not show all x-labels, so I am going to send you new figures. I assume it is directly to you and not to this ticket. Thank you in advance Diana

charlottejmc @.***> escreveu (quinta, 5/09/2024 à(s) 09:47):

Olá @ericbrasiln https://github.com/ericbrasiln e @dianamsmpsantos https://github.com/dianamsmpsantos,

Pode encontrar os ficheiros principais aqui:

Pode consultar a pré-visualização da lição aqui:

- http://programminghistorian.github.io/ph-submissions/pt/esbocos/originais/visualizacao-basica-dados-tabulares-R

Hello @dianamsmpsantos https://github.com/dianamsmpsantos, my notes on this submission are pretty much the same as those I outlined in my comment https://github.com/programminghistorian/ph-submissions/issues/599#issuecomment-2330726031 on your other lesson, Investigar a literatura lusófona através dos tempos usando a Literateca:

  • The code is looking a little strange, for example at lines 112-114; 153-155; 159-162... Did you mean to separate the code individually line by line, or were you hoping for them to appear as code blocks instead? If you'd like them to appear as code blocks, I can make that change for you. In general, you might find it easier to read and write your code by simply using single backticks around short bits of code (in-line, or single lines of code).
  • I notice you have included an asset https://github.com/programminghistorian/ph-submissions/tree/gh-pages/assets/visualizacao-basica-dados-tabulares-R, but this file not is linked to directly from within the lesson (so that readers can access it). Would you be able to add the link in where relevant? You can point directly to the file on Github, for example like this: dadosPeriodLit.tsv.
  • Finally, I saw that you provided 'alt-text' for all images, thank you! Unfortunately, it is currently a little under-descriptive, so I'd like to ask whether you might be able to try adding some more information to them (please see my other comment for further details).

— Reply to this email directly, view it on GitHub https://github.com/programminghistorian/ph-submissions/issues/624#issuecomment-2330839062, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6H44WOGUPJZ7IBWH7NKQLZVAEAPAVCNFSM6AAAAABMHDMBEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZQHAZTSMBWGI . You are receiving this because you were mentioned.Message ID: @.***>

charlottejmc commented 1 week ago

Hi @dianamsmpsantos, I've received your images and have now switched them in the image folder!

If you could also tick off the checkboxes in my comment above when you have resolved those queries, that would be perfect.

Thank you! ✨

dianamsmpsantos commented 1 week ago

I think I ticked them off. Did I? Thanks again!

anisa-hawes commented 1 week ago

Olá Diana @dianamsmpsantos,

What's happening now?

Your lesson has been moved to the next phase of our workflow which is Phase 2: Initial Edit.

In this phase, your editor Eric @ericbrasiln will read your lesson, and provide some initial feedback. Eric will post feedback and suggestions as a comment in this issue, so that you can revise your draft in the following phase (Phase 3: Revision 1).

%%{init: { 'logLevel': 'debug', 'theme': 'dark', 'themeVariables': {
              'cScale0': '#444444', 'cScaleLabel0': '#ffffff',
              'cScale1': '#886814', 'cScaleLabel1': '#ffffff',
              'cScale2': '#444444', 'cScaleLabel2': '#ffffff'
       } } }%%
timeline
Section Phase 1 <br> Submission
Who worked on this? : Publishing Assistant (@charlottejmc) 
All  Phase 1 tasks completed? : Yes
Section Phase 2 <br> Initial Edit
Who's working on this? : Editor (@ericbrasiln)  
Expected completion date? : October 11
Section Phase 3 <br> Revision 1
Who's responsible? : Author (@dianamsmpsantos) 
Expected timeframe? : ~30 days after feedback is received

Note: The Mermaid diagram above may not render on GitHub mobile. Please check in via desktop when you have a moment.