separate `vbmeta` does not seem to be properly treated in the survival scripts

[Iey4iej3]

On my Samsung S6 Lite, there is a separate vbmeta partition. When I update LOS, the system cannot boot anymore, saying that the magic code and the signature of vbmeta is incorrect.

The terminal output of survival scripts is however all "OK".

In the guide of magisk, these cases are distinguished manually.

It can only be solved by formatting system partition and flash again LOS, then Lygisk.

[binarynoise]

Do you also get this error if you use Magisk instead of Lygisk?

[Iey4iej3]

This error does not exist in magisk since it has no survival script.

[Linux4]

On my Samsung S6 Lite, there is a separate vbmeta partition. When I update LOS, the system cannot boot anymore, saying that the magic code and the signature of vbmeta is incorrect.

The terminal output of survival scripts is however all "OK".

In the guide of magisk, these cases are distinguished manually.

It can only be solved by formatting system partition and flash again LOS, then Lygisk.

The vbmeta shipped with your ROM disables verification already, so the issue must be something else. I rather think the issue is that it DOES patch vbmeta since gta4xl* devices require a special non-standard disabled vbmeta.

[Iey4iej3]

I am not sure that it is a matter of ROM, because the error about magic code and signature appear in download (ODIN) mode. It is impossible to power-off then, and later I find it possible to boot into the (LOS) recovery. I tried to reflash LOS, and the error persisted. It seems that it is the bootloader which checks the validity of vbmeta — the error message is shown in the download mode, not by the ROM.

[Linux4]

I am not sure that it is a matter of ROM, because the error about magic code and signature appear in download (ODIN) mode. It is impossible to power-off then, and later I find it possible to boot into the (LOS) recovery. I tried to reflash LOS, and the error persisted. It seems that it is the bootloader which checks the validity of vbmeta — the error message is shown in the download mode, not by the ROM.

Well you didn't properly read my message then, wasn't saying it's the ROMs fault, why would I even, I'm literally the maintainer

[Iey4iej3]

Sorry for the previous misunderstandings.

I rather think the issue is that it DOES patch vbmeta

Let me be a bit more precise: I think that "it" here is only about the survival scripts — flashing Lygisk in a clean system won't lead to this issue. And I add that flashing Lygisk without first formatting the system partition and reinstalling the ROM failed — it complained that the image is non-standard.

[binarynoise]

It does not seem like a general problem. I do own a Tab S6 Lite too and Lygisk works without problems so far. I just flashed a los update and it installed without problems.

It seems like an issue with your device. If you really want, you could try to re-flash/update firmware from the los wiki: WiFi | LTE, wipe system and try again with a fresh installation.

[Iey4iej3]

I updated the firmware to SM-P610-P610XXU2EVI1 (used to be the August build), and it seems that the issue persists. I am flashing LOS for MicroG, but I don't think that this would affect. More precisely, here is the steps to reproduce the issue:

1. Wipe system partition;
2. Flash LOS;
3. Flash Lygisk 25.2;
4. Reboot to system, and then to recovery again;
5. Flash LOS again to test addon.d.

Then it reboots into the Download mode, with error messages as follows.

ODIN MODE (BOOT Load Fail)
load_kernel: Could not do Normal boot. (invalid magic)
vbmeta: Error verifying vbmeta image: OK_NOT_SIGNED (3)
boot: Hash of data does not match digest in descriptor. [2nd] (3)
Calculated Hash of (boot) : a238235163, (VEMETA) : 717494f418
CUSTOM VBMETA
VBMETA : No sign info
VBMETA ,

I look at the recovery log /cache/recovery/last_log, and it contains ! Unable to extract zip file!

relevant log

``` [ 136.492295] Target: samsung/lineage_gta4xlwifi/gta4xlwifi:12/SQ3A.220705.004/eng.root.20221010.235950:userdebug/dev-keys [ 136.495861] Extracted file "/tmp/install/bin/backuptool.functions" [ 136.496321] Extracted file "/tmp/install/bin/backuptool.sh" [ 136.496397] Extracted 2 file(s) [ 136.497559] about to run program [/tmp/install/bin/backuptool.sh] with 5 args [ 138.888598] ******************************* [ 138.888655] Please install Magisk v20.4+! [ 138.888672] ******************************* [ 138.969665] ******************************* [ 138.969717] Please install Magisk v20.4+! [ 138.969728] ******************************* [ 139.053008] ******************************* [ 139.053224] Please install Magisk v20.4+! [ 139.053272] ******************************* [ 139.340388] ! Unable to extract zip file! [ 139.353001] ! Unable to extract zip file! [ 139.366258] ! Unable to extract zip file! [ 140.501665] [libfs_mgr]Unmapped logical partition system [ 140.526086] [libfs_mgr]Unmapped logical partition vendor [ 140.542573] [libfs_mgr]Unmapped logical partition product [ 140.557690] [libfs_mgr]Unmapped logical partition odm [ 140.574137] [libfs_mgr]Unmapped logical partition system_ext [ 140.587375] [liblp]Partition system will resize from 0 bytes to 851324928 bytes [ 140.589208] [liblp]Partition vendor will resize from 0 bytes to 197124096 bytes [ 140.590947] [liblp]Partition product will resize from 0 bytes to 472412160 bytes [ 140.592454] [liblp]Partition odm will resize from 0 bytes to 790528 bytes [ 140.594289] [liblp]Partition system_ext will resize from 0 bytes to 273588224 bytes [ 140.602090] [liblp]Updated logical partition table at slot 0 on device /dev/block/by-name/super [ 140.608608] Wrote updated marker to /cache/recovery/dynamic_partition_metadata.UPDATED [ 140.608800] Patching system image unconditionally... [ 140.608915] performing update [ 140.639225] [libfs_mgr]Created logical partition system on device /dev/block/dm-0 [ 140.641271] blockimg version is 4 [ 140.641364] maximum stash entries 0 [ 140.641490] creating stash /cache/recovery/cc46ebfd04058569d0c6c1431c6af6c1328458e4 [ 140.643525] 174350336 bytes free on /cache (0 needed) [ 140.643836] /cache/recovery/last_command doesn't exist. [ 140.643963] writing 1024 blocks of new data [ 140.834761] writing 1024 blocks of new data [ 141.126681] writing 1024 blocks of new data [ 141.345222] writing 1024 blocks of new data [ 141.504005] writing 1024 blocks of new data [ 141.693202] writing 1024 blocks of new data [ 141.886381] writing 1024 blocks of new data [ 142.081840] writing 1024 blocks of new data [ 142.296998] writing 1024 blocks of new data [ 142.565234] writing 1024 blocks of new data [ 142.812750] writing 1024 blocks of new data [ 143.081132] writing 1024 blocks of new data [ 143.263140] writing 1024 blocks of new data [ 143.462437] writing 1024 blocks of new data [ 143.691806] writing 1024 blocks of new data [ 143.930884] writing 1024 blocks of new data [ 144.144305] writing 1024 blocks of new data [ 144.406436] writing 1024 blocks of new data [ 144.576765] writing 1024 blocks of new data [ 144.793353] writing 1024 blocks of new data [ 145.041466] writing 1024 blocks of new data [ 145.190294] writing 1024 blocks of new data [ 145.457179] writing 1024 blocks of new data [ 145.689706] writing 1024 blocks of new data [ 145.937199] writing 1024 blocks of new data [ 146.080379] writing 1024 blocks of new data [ 146.357169] writing 1024 blocks of new data [ 146.532791] writing 1024 blocks of new data [ 146.753737] writing 1024 blocks of new data [ 146.939973] writing 1024 blocks of new data [ 147.163782] writing 1024 blocks of new data [ 147.421207] writing 1024 blocks of new data [ 147.603164] writing 1024 blocks of new data [ 147.840124] writing 1024 blocks of new data [ 148.040028] writing 1024 blocks of new data [ 148.281145] writing 1024 blocks of new data [ 148.468222] writing 1024 blocks of new data [ 148.729142] writing 1024 blocks of new data [ 148.915894] writing 1024 blocks of new data [ 149.161179] writing 1024 blocks of new data [ 149.365787] writing 1024 blocks of new data [ 149.621257] writing 1024 blocks of new data [ 149.846005] writing 1024 blocks of new data [ 150.084601] writing 1024 blocks of new data [ 150.276026] writing 1024 blocks of new data [ 150.528873] writing 1024 blocks of new data [ 150.794814] writing 1024 blocks of new data [ 150.996807] writing 1024 blocks of new data [ 151.249129] writing 1024 blocks of new data [ 151.434195] writing 1024 blocks of new data [ 151.705133] writing 1024 blocks of new data [ 151.877123] writing 1024 blocks of new data [ 152.105231] writing 1024 blocks of new data [ 152.280192] writing 1024 blocks of new data [ 152.457182] writing 1024 blocks of new data [ 152.701101] writing 1024 blocks of new data [ 152.989197] writing 1024 blocks of new data [ 153.228043] writing 1024 blocks of new data [ 153.445146] writing 1024 blocks of new data [ 153.586840] writing 1024 blocks of new data [ 153.727603] writing 1024 blocks of new data [ 153.928002] writing 1024 blocks of new data [ 154.268511] writing 1024 blocks of new data [ 154.589179] writing 1024 blocks of new data [ 154.882117] writing 1024 blocks of new data [ 155.241144] writing 1024 blocks of new data [ 155.518020] writing 1024 blocks of new data [ 155.800076] writing 1024 blocks of new data [ 156.032013] writing 1024 blocks of new data [ 156.228302] writing 1024 blocks of new data [ 156.291625] I:current maximum temperature: 35000 [ 156.412156] writing 1024 blocks of new data [ 156.681203] writing 1024 blocks of new data [ 156.990796] writing 1024 blocks of new data [ 157.234670] writing 1024 blocks of new data [ 157.596544] writing 1024 blocks of new data [ 157.936543] writing 1024 blocks of new data [ 158.213123] writing 1024 blocks of new data [ 158.352651] writing 1024 blocks of new data [ 158.579767] writing 1024 blocks of new data [ 158.798532] writing 1024 blocks of new data [ 159.117583] writing 1024 blocks of new data [ 159.377982] writing 1024 blocks of new data [ 159.545880] writing 1024 blocks of new data [ 159.766584] writing 1024 blocks of new data [ 160.039473] writing 1024 blocks of new data [ 160.260003] writing 1024 blocks of new data [ 160.470884] writing 1024 blocks of new data [ 160.645388] writing 1024 blocks of new data [ 160.847078] writing 1024 blocks of new data [ 161.093156] writing 1024 blocks of new data [ 161.368928] writing 1024 blocks of new data [ 161.575668] writing 1024 blocks of new data [ 161.742737] writing 1024 blocks of new data [ 161.925973] writing 1024 blocks of new data [ 162.056570] writing 1024 blocks of new data [ 162.129235] writing 1024 blocks of new data [ 162.199124] writing 1024 blocks of new data [ 162.266531] writing 1024 blocks of new data [ 162.319300] writing 1024 blocks of new data [ 162.487154] writing 1024 blocks of new data [ 162.698806] writing 1024 blocks of new data [ 162.869116] writing 1024 blocks of new data [ 163.004642] writing 1024 blocks of new data [ 163.251762] writing 1024 blocks of new data [ 163.478547] writing 1024 blocks of new data [ 163.664897] writing 1024 blocks of new data [ 163.917150] writing 1024 blocks of new data [ 164.104969] writing 1024 blocks of new data [ 164.345128] writing 1024 blocks of new data [ 164.583788] writing 1024 blocks of new data [ 164.957278] writing 1024 blocks of new data [ 165.162698] writing 1024 blocks of new data [ 165.315505] writing 1024 blocks of new data [ 165.458193] writing 1024 blocks of new data [ 165.705222] writing 1024 blocks of new data [ 165.940034] writing 1024 blocks of new data [ 166.188240] writing 1024 blocks of new data [ 166.380589] writing 1024 blocks of new data [ 166.642117] writing 1024 blocks of new data [ 166.893164] writing 1024 blocks of new data [ 167.070503] writing 1024 blocks of new data [ 167.341136] writing 1024 blocks of new data [ 167.574953] writing 1024 blocks of new data [ 167.837142] writing 1024 blocks of new data [ 168.044253] writing 1024 blocks of new data [ 168.216798] writing 1024 blocks of new data [ 168.439925] writing 1024 blocks of new data [ 168.573997] writing 1024 blocks of new data [ 168.760204] writing 1024 blocks of new data [ 168.995904] writing 1024 blocks of new data [ 169.194366] writing 1024 blocks of new data [ 169.399852] writing 1024 blocks of new data [ 169.645130] writing 1024 blocks of new data [ 169.848231] writing 1024 blocks of new data [ 170.097775] writing 1024 blocks of new data [ 170.253941] writing 1024 blocks of new data [ 170.537138] writing 1024 blocks of new data [ 170.679530] writing 1024 blocks of new data [ 170.968191] writing 1024 blocks of new data [ 171.218868] writing 1024 blocks of new data [ 171.483462] writing 1024 blocks of new data [ 171.750323] writing 1024 blocks of new data [ 172.041162] writing 1024 blocks of new data [ 172.257463] writing 1024 blocks of new data [ 172.428777] writing 1024 blocks of new data [ 172.623169] writing 1024 blocks of new data [ 172.771599] writing 1024 blocks of new data [ 172.957255] writing 1024 blocks of new data [ 173.117538] writing 1024 blocks of new data [ 173.309865] writing 1024 blocks of new data [ 173.474756] writing 1024 blocks of new data [ 173.660098] writing 1024 blocks of new data [ 173.835797] writing 1024 blocks of new data [ 174.038429] writing 1024 blocks of new data [ 174.259496] writing 1024 blocks of new data [ 174.505140] writing 1024 blocks of new data [ 174.714724] writing 1024 blocks of new data [ 174.907762] writing 1024 blocks of new data [ 175.142198] writing 1024 blocks of new data [ 175.365237] writing 1024 blocks of new data [ 175.591577] writing 1024 blocks of new data [ 175.801918] writing 1024 blocks of new data [ 176.049222] writing 1024 blocks of new data [ 176.280213] writing 1024 blocks of new data [ 176.294557] I:current maximum temperature: 39000 [ 176.424283] writing 1024 blocks of new data [ 176.657420] writing 1024 blocks of new data [ 176.882554] writing 1024 blocks of new data [ 177.020962] writing 1024 blocks of new data [ 177.249104] writing 1024 blocks of new data [ 177.422024] writing 1024 blocks of new data [ 177.585953] writing 1024 blocks of new data [ 177.796732] writing 1024 blocks of new data [ 178.053157] writing 1024 blocks of new data [ 178.319753] writing 1024 blocks of new data [ 178.537007] writing 1024 blocks of new data [ 178.752399] writing 1024 blocks of new data [ 179.010269] writing 1024 blocks of new data [ 179.297231] writing 1024 blocks of new data [ 179.464754] writing 1024 blocks of new data [ 179.616212] writing 1024 blocks of new data [ 179.852284] writing 1024 blocks of new data [ 180.085150] writing 1024 blocks of new data [ 180.310449] writing 1024 blocks of new data [ 180.471729] writing 1024 blocks of new data [ 180.676341] writing 1024 blocks of new data [ 180.847452] writing 1024 blocks of new data [ 181.018118] writing 1024 blocks of new data [ 181.244717] writing 1024 blocks of new data [ 181.470548] writing 1024 blocks of new data [ 181.716937] writing 1024 blocks of new data [ 181.874131] writing 1024 blocks of new data [ 182.134173] writing 1024 blocks of new data [ 182.389148] writing 1024 blocks of new data [ 182.530100] writing 1024 blocks of new data [ 182.777111] writing 1024 blocks of new data [ 182.900672] writing 1024 blocks of new data [ 183.109178] writing 1024 blocks of new data [ 183.391337] writing 1024 blocks of new data [ 183.604197] writing 1024 blocks of new data [ 183.758896] writing 1024 blocks of new data [ 183.932801] writing 1024 blocks of new data [ 184.216220] writing 1024 blocks of new data [ 184.412794] writing 315 blocks of new data [ 184.480031] zeroing 680 blocks [ 184.518563] wrote 207843 blocks; expected 207843 [ 184.518618] stashed 0 blocks [ 184.518637] max alloc needed was 4096 [ 184.518653] deleting stash cc46ebfd04058569d0c6c1431c6af6c1328458e4 [ 184.520863] Wrote updated marker to /cache/recovery/cc46ebfd04058569d0c6c1431c6af6c1328458e4.UPDATED [ 184.822629] Patching vendor image unconditionally... [ 184.822724] performing update [ 184.839825] [libfs_mgr]Created logical partition vendor on device /dev/block/dm-1 [ 184.842327] blockimg version is 4 [ 184.842356] maximum stash entries 0 [ 184.842363] creating stash /cache/recovery/8c196ea633c934065ddf9f05370e83fdf52ed7c4 [ 184.842370] 174350336 bytes free on /cache (0 needed) [ 184.842376] /cache/recovery/last_command doesn't exist. [ 184.842382] writing 1024 blocks of new data [ 185.029326] writing 1024 blocks of new data [ 185.212384] writing 1024 blocks of new data [ 185.461115] writing 1024 blocks of new data [ 185.644982] writing 1024 blocks of new data [ 185.897193] writing 1024 blocks of new data [ 185.997838] writing 1024 blocks of new data [ 186.203290] writing 1024 blocks of new data [ 186.365166] writing 1024 blocks of new data [ 186.481095] writing 1024 blocks of new data [ 186.667284] writing 1024 blocks of new data [ 186.819907] writing 1024 blocks of new data [ 187.085892] writing 1024 blocks of new data [ 187.329891] writing 1024 blocks of new data [ 187.579541] writing 1024 blocks of new data [ 187.795546] writing 1024 blocks of new data [ 187.997093] writing 1024 blocks of new data [ 188.250181] writing 1024 blocks of new data [ 188.521199] writing 1024 blocks of new data [ 188.720386] writing 1024 blocks of new data [ 188.884794] writing 1024 blocks of new data [ 189.117628] writing 1024 blocks of new data [ 189.260127] writing 1024 blocks of new data [ 189.393178] writing 1024 blocks of new data [ 189.570480] writing 1024 blocks of new data [ 189.773135] writing 1024 blocks of new data [ 189.940540] writing 1024 blocks of new data [ 190.124636] writing 1024 blocks of new data [ 190.317219] writing 1024 blocks of new data [ 190.502275] writing 1024 blocks of new data [ 190.741245] writing 1024 blocks of new data [ 190.931508] writing 1024 blocks of new data [ 191.212314] writing 1024 blocks of new data [ 191.461154] writing 1024 blocks of new data [ 191.657397] writing 1024 blocks of new data [ 191.857554] writing 1024 blocks of new data [ 192.059375] writing 1024 blocks of new data [ 192.334286] writing 1024 blocks of new data [ 192.561256] writing 1024 blocks of new data [ 192.741800] writing 1024 blocks of new data [ 192.957196] writing 1024 blocks of new data [ 193.069750] writing 1024 blocks of new data [ 193.286502] writing 1024 blocks of new data [ 193.481127] writing 1024 blocks of new data [ 193.665445] writing 1024 blocks of new data [ 193.847264] writing 1024 blocks of new data [ 194.146259] writing 850 blocks of new data [ 194.271074] zeroing 172 blocks [ 194.293297] wrote 48126 blocks; expected 48126 [ 194.293387] stashed 0 blocks [ 194.293416] max alloc needed was 4096 [ 194.293695] deleting stash 8c196ea633c934065ddf9f05370e83fdf52ed7c4 [ 194.296964] Wrote updated marker to /cache/recovery/8c196ea633c934065ddf9f05370e83fdf52ed7c4.UPDATED [ 194.441104] Patching product image unconditionally... [ 194.441165] performing update [ 194.441639] [libfs_mgr]Created logical partition product on device /dev/block/dm-2 [ 194.443343] blockimg version is 4 [ 194.443403] maximum stash entries 0 [ 194.443418] creating stash /cache/recovery/d9ad44a4dbdae58644b399a49f0380b5e54d4fc6 [ 194.443586] 174350336 bytes free on /cache (0 needed) [ 194.443757] /cache/recovery/last_command doesn't exist. [ 194.443782] writing 1024 blocks of new data [ 194.665396] writing 1024 blocks of new data [ 194.943208] writing 1024 blocks of new data [ 195.226784] writing 1024 blocks of new data [ 195.466743] writing 1024 blocks of new data [ 195.693301] writing 1024 blocks of new data [ 195.921183] writing 1024 blocks of new data [ 196.099831] writing 1024 blocks of new data [ 196.295410] I:current maximum temperature: 36000 [ 196.331426] writing 1024 blocks of new data [ 196.554621] writing 1024 blocks of new data [ 196.800601] writing 1024 blocks of new data [ 197.045994] writing 1024 blocks of new data [ 197.329142] writing 1024 blocks of new data [ 197.513409] writing 1024 blocks of new data [ 197.780068] writing 1024 blocks of new data [ 198.012227] writing 1024 blocks of new data [ 198.235763] writing 1024 blocks of new data [ 198.388740] writing 1024 blocks of new data [ 198.633247] writing 1024 blocks of new data [ 198.811922] writing 1024 blocks of new data [ 199.059859] writing 1024 blocks of new data [ 199.248906] writing 1024 blocks of new data [ 199.497494] writing 1024 blocks of new data [ 199.685287] writing 1024 blocks of new data [ 199.897192] writing 1024 blocks of new data [ 200.046706] writing 1024 blocks of new data [ 200.260342] writing 1024 blocks of new data [ 200.462264] writing 1024 blocks of new data [ 200.664648] writing 1024 blocks of new data [ 200.882563] writing 1024 blocks of new data [ 201.119051] writing 1024 blocks of new data [ 201.302497] writing 1024 blocks of new data [ 201.570104] writing 1024 blocks of new data [ 201.825096] writing 1024 blocks of new data [ 202.050628] writing 1024 blocks of new data [ 202.244472] writing 1024 blocks of new data [ 202.505145] writing 1024 blocks of new data [ 202.703045] writing 1024 blocks of new data [ 202.914295] writing 1024 blocks of new data [ 203.112599] writing 1024 blocks of new data [ 203.342561] writing 1024 blocks of new data [ 203.540028] writing 1024 blocks of new data [ 203.781159] writing 1024 blocks of new data [ 204.009264] writing 1024 blocks of new data [ 204.223761] writing 1024 blocks of new data [ 204.449514] writing 1024 blocks of new data [ 204.665248] writing 1024 blocks of new data [ 204.884551] writing 1024 blocks of new data [ 205.138713] writing 1024 blocks of new data [ 205.340566] writing 1024 blocks of new data [ 205.487254] writing 1024 blocks of new data [ 205.736783] writing 1024 blocks of new data [ 205.952069] writing 1024 blocks of new data [ 206.201180] writing 1024 blocks of new data [ 206.449180] writing 1024 blocks of new data [ 206.622182] writing 1024 blocks of new data [ 206.810417] writing 1024 blocks of new data [ 207.048802] writing 1024 blocks of new data [ 207.227797] writing 1024 blocks of new data [ 207.490381] writing 1024 blocks of new data [ 207.749119] writing 1024 blocks of new data [ 207.936837] writing 1024 blocks of new data [ 208.171185] writing 1024 blocks of new data [ 208.335123] writing 1024 blocks of new data [ 208.558492] writing 1024 blocks of new data [ 208.834461] writing 1024 blocks of new data [ 208.993126] writing 1024 blocks of new data [ 209.220685] writing 1024 blocks of new data [ 209.465355] writing 1024 blocks of new data [ 209.679877] writing 1024 blocks of new data [ 209.920013] writing 1024 blocks of new data [ 210.184147] writing 1024 blocks of new data [ 210.429143] writing 1024 blocks of new data [ 210.664000] writing 1024 blocks of new data [ 210.956596] writing 1024 blocks of new data [ 211.237414] writing 1024 blocks of new data [ 211.434857] writing 1024 blocks of new data [ 211.699405] writing 1024 blocks of new data [ 211.973108] writing 1024 blocks of new data [ 212.195159] writing 1024 blocks of new data [ 212.371217] writing 1024 blocks of new data [ 212.637251] writing 1024 blocks of new data [ 212.871050] writing 1024 blocks of new data [ 213.081886] writing 1024 blocks of new data [ 213.336658] writing 1024 blocks of new data [ 213.574413] writing 1024 blocks of new data [ 213.875784] writing 1024 blocks of new data [ 214.179696] writing 1024 blocks of new data [ 214.471044] writing 1024 blocks of new data [ 214.784581] writing 1024 blocks of new data [ 215.085253] writing 1024 blocks of new data [ 215.280612] writing 1024 blocks of new data [ 215.513455] writing 1024 blocks of new data [ 215.744840] writing 1024 blocks of new data [ 216.018134] writing 1024 blocks of new data [ 216.229611] writing 1024 blocks of new data [ 216.298395] I:current maximum temperature: 38000 [ 216.405211] writing 1024 blocks of new data [ 216.636033] writing 1024 blocks of new data [ 216.857848] writing 1024 blocks of new data [ 217.087571] writing 1024 blocks of new data [ 217.343705] writing 1024 blocks of new data [ 217.528364] writing 1024 blocks of new data [ 217.762725] writing 1024 blocks of new data [ 217.997294] writing 1024 blocks of new data [ 218.272364] writing 1024 blocks of new data [ 218.518490] writing 1024 blocks of new data [ 218.748202] writing 1024 blocks of new data [ 218.908417] writing 1024 blocks of new data [ 219.185099] writing 1024 blocks of new data [ 219.380826] writing 1024 blocks of new data [ 219.628702] writing 1024 blocks of new data [ 219.796807] writing 1024 blocks of new data [ 220.043502] writing 265 blocks of new data [ 220.120238] zeroing 382 blocks [ 220.150278] wrote 115335 blocks; expected 115335 [ 220.150338] stashed 0 blocks [ 220.150353] max alloc needed was 4096 [ 220.150372] deleting stash d9ad44a4dbdae58644b399a49f0380b5e54d4fc6 [ 220.154226] Wrote updated marker to /cache/recovery/d9ad44a4dbdae58644b399a49f0380b5e54d4fc6.UPDATED [ 220.358288] Patching odm image unconditionally... [ 220.358387] performing update [ 220.383210] [libfs_mgr]Created logical partition odm on device /dev/block/dm-3 [ 220.383264] blockimg version is 4 [ 220.383277] maximum stash entries 0 [ 220.383288] creating stash /cache/recovery/eaf85df4c5bdde4709732f16fc3899f3e6a67e75 [ 220.383299] 174350336 bytes free on /cache (0 needed) [ 220.383310] /cache/recovery/last_command doesn't exist. [ 220.383321] writing 176 blocks of new data [ 220.415761] zeroing 17 blocks [ 220.424298] wrote 193 blocks; expected 193 [ 220.424384] stashed 0 blocks [ 220.424441] max alloc needed was 4096 [ 220.424512] deleting stash eaf85df4c5bdde4709732f16fc3899f3e6a67e75 [ 220.427888] Wrote updated marker to /cache/recovery/eaf85df4c5bdde4709732f16fc3899f3e6a67e75.UPDATED [ 220.428804] Patching system_ext image unconditionally... [ 220.428901] performing update [ 220.455468] [libfs_mgr]Created logical partition system_ext on device /dev/block/dm-4 [ 220.456621] blockimg version is 4 [ 220.456742] maximum stash entries 0 [ 220.456878] creating stash /cache/recovery/9d47fe26ec66c447facdc711d3627fbcd1e16d3f [ 220.457520] 174350336 bytes free on /cache (0 needed) [ 220.457901] /cache/recovery/last_command doesn't exist. [ 220.458074] writing 1024 blocks of new data [ 220.668635] writing 1024 blocks of new data [ 220.834373] writing 1024 blocks of new data [ 221.059146] writing 1024 blocks of new data [ 221.283399] writing 1024 blocks of new data [ 221.490457] writing 1024 blocks of new data [ 221.722808] writing 1024 blocks of new data [ 221.948659] writing 1024 blocks of new data [ 222.156192] writing 1024 blocks of new data [ 222.368247] writing 1024 blocks of new data [ 222.600146] writing 1024 blocks of new data [ 222.833208] writing 1024 blocks of new data [ 223.029710] writing 1024 blocks of new data [ 223.251063] writing 1024 blocks of new data [ 223.513212] writing 1024 blocks of new data [ 223.731342] writing 1024 blocks of new data [ 223.976522] writing 1024 blocks of new data [ 224.231690] writing 1024 blocks of new data [ 224.506090] writing 1024 blocks of new data [ 224.654343] writing 1024 blocks of new data [ 224.787136] writing 1024 blocks of new data [ 224.989170] writing 1024 blocks of new data [ 225.217654] writing 1024 blocks of new data [ 225.428556] writing 1024 blocks of new data [ 225.629280] writing 1024 blocks of new data [ 225.825211] writing 1024 blocks of new data [ 225.976456] writing 1024 blocks of new data [ 226.157650] writing 1024 blocks of new data [ 226.344915] writing 1024 blocks of new data [ 226.503754] writing 1024 blocks of new data [ 226.616133] writing 1024 blocks of new data [ 226.886549] writing 1024 blocks of new data [ 227.039970] writing 1024 blocks of new data [ 227.235753] writing 1024 blocks of new data [ 227.476609] writing 1024 blocks of new data [ 227.707466] writing 1024 blocks of new data [ 227.990090] writing 1024 blocks of new data [ 228.228518] writing 1024 blocks of new data [ 228.457125] writing 1024 blocks of new data [ 228.624188] writing 1024 blocks of new data [ 228.786750] writing 1024 blocks of new data [ 229.075730] writing 1024 blocks of new data [ 229.341128] writing 1024 blocks of new data [ 229.515552] writing 1024 blocks of new data [ 229.681572] writing 1024 blocks of new data [ 229.898626] writing 1024 blocks of new data [ 230.095102] writing 1024 blocks of new data [ 230.267028] writing 1024 blocks of new data [ 230.436532] writing 1024 blocks of new data [ 230.659316] writing 1024 blocks of new data [ 230.896430] writing 1024 blocks of new data [ 231.119569] writing 1024 blocks of new data [ 231.373558] writing 1024 blocks of new data [ 231.595427] writing 1024 blocks of new data [ 231.852641] writing 1024 blocks of new data [ 232.093086] writing 1024 blocks of new data [ 232.361168] writing 1024 blocks of new data [ 232.554859] writing 1024 blocks of new data [ 232.779392] writing 1024 blocks of new data [ 233.029137] writing 1024 blocks of new data [ 233.183550] writing 1024 blocks of new data [ 233.437290] writing 1024 blocks of new data [ 233.685294] writing 1024 blocks of new data [ 233.921210] writing 1024 blocks of new data [ 234.138757] writing 1024 blocks of new data [ 234.402325] writing 4 blocks of new data [ 234.411064] zeroing 230 blocks [ 234.431469] wrote 66794 blocks; expected 66794 [ 234.431533] stashed 0 blocks [ 234.431545] max alloc needed was 4096 [ 234.431715] deleting stash 9d47fe26ec66c447facdc711d3627fbcd1e16d3f [ 234.435196] Wrote updated marker to /cache/recovery/9d47fe26ec66c447facdc711d3627fbcd1e16d3f.UPDATED [ 234.601550] about to run program [/tmp/install/bin/backuptool.sh] with 5 args [ 236.299096] I:current maximum temperature: 39000 [ 236.992423] ******************************* [ 236.992536] Please install Magisk v20.4+! [ 236.992606] ******************************* [ 237.078659] ******************************* [ 237.078764] Please install Magisk v20.4+! [ 237.078811] ******************************* [ 237.159255] ******************************* [ 237.159364] Please install Magisk v20.4+! [ 237.159411] ******************************* [ 237.434952] ! Unable to extract zip file! [ 237.452341] ! Unable to extract zip file! [ 237.464512] ! Unable to extract zip file! [ 239.830585] Patching dtbo image unconditionally... [ 239.920214] Patching vbmeta image unconditionally... [ 253.786889] mount: mounting /mnt/system/system on /system failed: No such file or directory [ 256.302890] I:current maximum temperature: 36000 [ 256.864767] mount: can't find /persist in /etc/fstab [ 257.177248] /tmp/addon.d/99-magisk.sh: eval: line 1: /system/bin/dalvikvm: not found [ 257.379116] stat: can't stat 'new-boot.img': No such file or directory [ 257.387777] sh: bad number [ 257.403948] cat: can't open 'new-boot.img': No such file or directory [ 267.725159] [ 267.791403] W:failed to read uncrypt status: No such file or directory [ 267.791696] I:current maximum temperature: 45000 [ 267.791787] I:/sideload/package.zip [ 267.791835] 1 [ 267.791879] time_total: 205 [ 267.791922] retry: 0 [ 267.791977] target_build: eng.root.20221010.235950 [ 267.792020] bytes_written_dm-0: 851324928 [ 267.792062] bytes_stashed_dm-0: 0 [ 267.792106] bytes_written_dm-1: 197124096 [ 267.792149] bytes_stashed_dm-1: 0 [ 267.792192] bytes_written_dm-2: 472412160 [ 267.792234] bytes_stashed_dm-2: 0 [ 267.792277] bytes_written_dm-3: 790528 [ 267.792327] bytes_stashed_dm-3: 0 [ 267.792369] bytes_written_dm-4: 273588224 [ 267.792411] bytes_stashed_dm-4: 0 [ 267.792453] temperature_start: 31000 [ 267.792495] temperature_end: 45000 [ 267.792537] temperature_max: 45000 [ 267.792580] [ 267.792655] I:Command 0 finished with 1 [ 269.209305] minadbd W 10-13 19:33:02 3759 3759 sockets.cpp:279] timeout expired while flushing socket, closing [ 269.210095] minadbd I 10-13 19:33:02 3759 3770 minadbd_services.cpp:159] revents: 16 [ 269.388738] I:Socket has been closed [ 272.603725] [ 272.603789] Install completed with status 0. ```

[Iey4iej3]

It seems to me that the log is not informative (I don't see any debug log of 99-magisk in /cache/recovery/log, except something like "Please install Magisk v20.4+!", which is produced by module_installer.sh if I am not mistaken. I look at /system/addon.d/magisk/, and find that the file magiskboot is of size 0. Is that normal?

[binarynoise]

So if I understand correctly, in general installation works, but not with addon.d.

Looking at the log, your partitions seem messed up (239 ff.).

Does your phone boot, if you flash only LOS, first clean then as update?

Do these problems persist if you use LOS instead of LOS for μG?

Do these problems persist with older versions of Lygisk?

Do these problems persist, if you flash stock and go back to LOS again?

To enable more logging, add set -x at the beginning of each sh file in the Lygisk zip

[Iey4iej3]

Thanks. After some testings, the real reason is the limit of the system partition — microg occupies some space and there is no further space for backups of Lygisk.

/dev/block/dm-0    817128 817128         0 100% /mnt/system

[Iey4iej3]

It might be better to give warnings during the first installation when copying to addon.d failed. Currently, it looks all successful.

[binarynoise]

Yeah, error handling is not good. We'll add it on our TODO for the next Release

[binarynoise]

But you might also go talk to the microG-people why their stuff takes up so much space. Or why they don't leave some free space after the dynamic resize (which could be the root problem here)

[Iey4iej3]

Yes, after isolating this issue, I find it already reported https://github.com/lineageos4microg/docker-lineage-cicd/issues/358