Jam should show from top

programsam / binkjs

Music archival site BINK, rewritten as a Node.js express app

0 stars 1 forks source link

Jam should show from top #100

Closed programsam closed 5 years ago

programsam commented 6 years ago

If you go click a jam to view it right now, it’ll load just fine but it’ll be scrolled to the center of the page. No idea why that’s happening. Anyway, throughout, when you view something you should be viewing from the top.

This seems worse on mobile.

programsam commented 5 years ago

SUPER easy to fix:

$(window).scrollTop(0);

programsam commented 5 years ago

Put this not just when loading jams but actually whenever you change contexts. Go from looking at jams on a particular band to looking at a musician's info? Scroll to top. Similar cases abound.

Fixed in https://github.com/programsam/binkjs/commit/9364881a9e4e057bae9120ba7ac83034ac0469c4