programsam / binkjs

Music archival site BINK, rewritten as a Node.js express app
0 stars 1 forks source link

Move away from .aws/credentials #143

Closed programsam closed 5 months ago

programsam commented 5 months ago

As per https://github.com/programsam/binkjs?tab=readme-ov-file#aws-credentials-awscli...

Currently, to run BINK.js, a user must download and install awscli and even go so far as to add a ~/.aws/credentials file such that BINK is able to talk to Amazon AWS S3.

Specifically, this is because of this line right here: https://github.com/programsam/binkjs/blob/master/lib/binks3.js#L19, which says that we are going to use the credential-provider-ini way of authentication to S3.

So this issue is to track the work of having those credentials provided to the @aws-sdk/client-s3 in another way. The ideal way would be to use the settings.json file that we already have established, although, I ran into issues with that earlier this year.

This part of the AWS is not specific to S3 service that Amazon provides. Authenticating to AWS as a whole is handled through a credential provider. Related documentation should be around "Loading AWS credentials in Node.js". Specifically, we are using the Node.js v3 Client SDK, which is key for using the correct docs. The credential providers package seems like the right place.

programsam commented 5 months ago

This is done.