search

programsam / binkjs

Music archival site BINK, rewritten as a Node.js express app
0 stars 1 forks source link

Render modals from pug #69

Closed programsam closed 6 years ago

programsam commented 6 years ago

At the moment, the modals for alerts and admin login are rendered from hidden divs built into the index.

Change these to be queries from /views that are appended and then potentially even removed from the DOM when dismissed.

programsam commented 6 years ago

As far as the admin login, this is done. As far as the alert modal, I've rethought this and decided that it needs to be a part of the page: if the server is down or having a problem and it can't serve up the html for the modal, then you're screwed twice. So the alert modal is included in the index as a hidden div; javascript will render it if necessary regardless of the backend circumstances.