search

progre / tslint-config-airbnb

[Deprecated] A TSLint config for Airbnb JavaScript Style
Other
464 stars 58 forks source link

Update to tslint-microsoft-contrib@6.0.0-beta #58

Open joelalejandro opened 6 years ago

joelalejandro commented 6 years ago

tslint-microsoft-config has released a new major version that fixes, among other things, an issue with Symbol.iterator and Symbol.asyncIterator not being supported as function names. Full release notes are here. This comment mentions that there are some breaking changes.

So, this package should update its version of tslint-microsoft-config. The question is: should it be under a major release (tslint-config-airbnb@6.0.0) due to the breaking changes of tslint-microsoft-config?

progre commented 6 years ago

Thanks for your information.

The question

I'll not update majour version of tslint-config-airbnb. because I think it's easier to understand to match with the major version of tslint.

JoshuaKGoldberg commented 5 years ago

One note: https://www.npmjs.com/package/tslint-microsoft-contrib/v/6.0.0 is now available and on longer in beta, if that helps at all.

Darep commented 5 years ago

If someone wants to run 6.0.0 already, you can add a custom resolution to package.json:

{
  ...
  "resolutions": {
    "**/tslint-microsoft-contrib": "^6.0.0"
  },
  ...
}
robgraeber commented 5 years ago

^ To save people some time, resolutions is a field used by yarn only and not npm.

lizzzp1 commented 5 years ago

Would like this update as well, there are some accessibility additions in the update.

TheLogan commented 5 years ago

This seems to still be an issue?

msegers commented 5 years ago

We're also waiting for this update. Does this require a PR? Should be fairly simple right?

dosentmatter commented 5 years ago

I think import-name exceptions has a bug on the currently used tslint-microsoft-contrib@5.2.1. I forced it to use 6.2.0 and the error went away.