progress / JSDO

Client side TypeScript library to access Progress® Data Object Services
Other
23 stars 27 forks source link

Possible issue with offline event trigger #270

Open W1nstar opened 5 years ago

W1nstar commented 5 years ago

Hello,

I am trying to use the offline event to do some logic on my app. Turns out, it is never called.

In the processPingResult, there's this line:

        if (args.fireEventIfOfflineChange) {
            if (wasOnline && !connectedBeforeCallback) {
                that.trigger("offline", that, args.offlineReason, null);
            } else if (!wasOnline && connectedBeforeCallback) {
                that.trigger("online", that, null);
            }
        }

On my tests, wasOnline and connectedBeforeCallback are both true, therefore it always try to trigger the online event. My tests are very simple, I just stop OEPAS and hope for the event to trigger, but it does not. By debugging this _processPingResult function I can see that the function correctly identifies the reason of the ping failur (server offline), but when it evaluates the triggers, it always resorts to trigger online instead of online.

Can you guys confirm it's an error?

Thank you.