search

progressivetech / net.ourpowerbase.qrcodecheckin

QRCode Checkin allows you to send an email that contains a scanable code to the registered participants for your event.
Other
16 stars 15 forks source link

Problem with transparent PNG background #8

Closed davyrhys closed 3 years ago

davyrhys commented 5 years ago

I installed the extension so I can send QR code URLs to event participants' mobile phones (using CiviSMS). Clicking the URL opens the QR Code image (png file) for scanning and works perfectly. Thanks!

However I experienced a hurdle in that the browser background on my Chrome and Brave browsers is black, and because the default QR Code image has a transparent background the QR Code was not visible.

I fixed this by editing qrcodecheckin.php to generate a jpg rather than png image.

jmcclelland commented 5 years ago

Oh wow, didn't think of that. I wonder if there's an option when generating the png to not make it transparent?

davyrhys commented 5 years ago

I found a transparency option in /vendor/chillerian/php-qrcode/src/Traits/QROptionsTrait.php....

...

DAVY IVINS T: 011 656 0946 C: 084 207 8148 davy.ivins@gmail.com

On Wed, 7 Aug 2019 at 19:09, Jamie McClelland notifications@github.com wrote:

Oh wow, didn't think of that. I wonder if there's an option when generating the png to not make it transparent?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/progressivetech/net.ourpowerbase.qrcodecheckin/issues/8?email_source=notifications&email_token=AAH6UVANLUT66CONVWNDGTDQDL6WFA5CNFSM4IJYUDQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ZCWSA#issuecomment-519187272, or mute the thread https://github.com/notifications/unsubscribe-auth/AAH6UVCOY6B3M5XWS5LUO6DQDL6WFANCNFSM4IJYUDQQ .

jmcclelland commented 3 years ago

Thanks for the feedback, we should be creating non-transparent pngs now.