progressivetech / net.ourpowerbase.sumfields

The Summary Fields extension creates read-only custom data fields that extend Contact and are automatically populated with up-to-date totals such as total lifetime contributions, last contribution amount, last attended event, etc.
Other
8 stars 29 forks source link

Variables in civicrm_setting should have their own namespace #100

Open alexymik opened 1 year ago

alexymik commented 1 year ago

Currently the variables for Summary Fields are stored in the civicrm_setting table using their "local" names:

I would suggest to namespace these to something like sumfields_, ex:

This would make it more clear what the variables are when viewed outside the Summary Field context.

sumfields_get_setting() could be modified to directly use this as a prefix so most of the code can remain the same.

jmcclelland commented 1 year ago

Yes - that is a good idea. Would you be up for a PR? I think it would also need an upgrade step to rename the existing settings.