search

progressivetech / net.ourpowerbase.sumfields

The Summary Fields extension creates read-only custom data fields that extend Contact and are automatically populated with up-to-date totals such as total lifetime contributions, last contribution amount, last attended event, etc.
Other
8 stars 29 forks source link

Can remove some settings cruft #21

Closed eileenmcnaughton closed 5 years ago

eileenmcnaughton commented 7 years ago

There is if (version > 4.7. alpha) around the use of the api to create settings - but that api call has worked since 4.2. It's only the other methodology that has changed. The settings api calls will work for $config and settings on all versions. It's only the other functions that have changed over time

jmcclelland commented 7 years ago

Thanks Eileen. Are you referring to the sumfields_save_setting/sumfields_get_setting functions?

In both cases I'm using the API, but pre 4.7 I think I need the group_name for it to work (whereas after 4.7, group_name was removed so we'll get an error).

Or is there a different place you are referring to?

eileenmcnaughton commented 7 years ago

the group name should not be required pre 4.7 for the api calls - it was always optional

jmcclelland commented 5 years ago

cruft is removed.