search

progressivetech / net.ourpowerbase.sumfields

The Summary Fields extension creates read-only custom data fields that extend Contact and are automatically populated with up-to-date totals such as total lifetime contributions, last contribution amount, last attended event, etc.
Other
8 stars 29 forks source link

'Largest Contribution' includes Test contributions #63

Open zkrebs opened 5 years ago

zkrebs commented 5 years ago

Summary Fields v. 4.0.2 CiviCRM v. 5.16.3 Drupal 7

Summary Fields seem to be including contributions that are marked as a test - for instance, test event registrations. On the contribution tab, they are clearly marked as "Financial Type (test)".

Is this by design, or perhaps a small change is needed to omit them?

jmcclelland commented 5 years ago

That does appear to be a glaring oversight - we seem to exclude tests for the event counts, but not the contribution counts. Should be a simple fix to custom.php.

jmcclelland commented 5 years ago

I just fixed this problem via 2c9e040b08496e4ed68f960a5ed1fcb672e5e0d6 and 81b234876aa14d4c37f154010e92b1b2dc3a0d28. It is not yet in the latest release, but if you can install from this git repo and test that would be great.

zkrebs commented 5 years ago

I cloned the master branch and see that the changes work. The 'Largest Contribution' does not include test contribution any longer, so I can deduce it's doing the same for the rest. Thank you so much!