progrium / entrykit

Entrypoint tools for elegant, programmable containers
443 stars 29 forks source link

Fix race condition #15

Closed hoelzro closed 4 years ago

hoelzro commented 4 years ago

I found a race condition which results in a segfault - go test -count 1000 ./... without 0a67846 manages to reproduce the issue very reliably.

Ideally, I'd like to handle the error case of cmd.Start() more elegantly (eg. sending a signal to started children and waiting for them to terminate), but this will do for now.