search

progrium / envy

Lightweight dev environments with a twist
MIT License
321 stars 21 forks source link

support github personal access tokens for web auth #22

Closed progrium closed 9 years ago

progrium commented 9 years ago

Should be able to auth using a personal access token as your username.

andyshinn commented 9 years ago

Also to note, this is probably the way for anyone using 2 facter authentication with GitHub (including me) to use Envy.

progrium commented 9 years ago

Can you confirm that you can use the github API with a personal access token to bypass 2 factor?

andyshinn commented 9 years ago

Actually, I noticed this at the bottom of the personal access tokens page:

Personal access tokens function like ordinary OAuth access tokens. They can be used instead of a password for Git over HTTPS, or can be used to authenticate to the API over Basic Authentication.

I just tested and the personal access token does work in place of the password already. Is it even worth making it work in place of the username?

progrium commented 9 years ago

Boom. Already done. Best features require no code change.