search

progrium / envy

Lightweight dev environments with a twist
MIT License
321 stars 21 forks source link

Automatically roll back when build fail? #28

Open mouyigang opened 9 years ago

mouyigang commented 9 years ago

I edited my Dockerfile to FROM mysql and obviously it won't work but I exited the session, before I realised the mistake, now I can't log in to that environment any more.

If this kind of situation happens, would it be nice to provide an option to reverse the Dockerfile change to last working state?

And I also wonder how to manually fix this, I attached the main docker instance and went to /data/users/[username]/envs and removed the whole folder named after that environment, didn't help.

progrium commented 9 years ago

There's a couple situations here. There's a bad build that will not finish making the image. This should already work fine on failure since the last image will still exist I think. Then there's a mistake that makes the image unusable even though it builds fine. Which one are you talking about?

mouyigang commented 9 years ago

Sorry for the late response, the later one. Thanks.