progrium / ginkgo

Python service microframework
http://ginkgo.readthedocs.org
MIT License
325 stars 51 forks source link

Complete ginkgo's separation from gevent, adding async modules for threading/eventlet, remove serve_forever #70

Closed inconshreveable closed 11 years ago

inconshreveable commented 12 years ago

This also merges in the eventlet branch.

I'm not entirely happy with the error message construction and enumeration of available async modules living in core.Service. Maybe we should throw a more specific error that we catch in the runner?

progrium commented 12 years ago

This all looks pretty great, but I didn't mean remove serve_forever, just the recursive part. It's sort of an expected idiom borrowed from gevent borrowed from Python stdlib servers.

kyleconroy commented 11 years ago

@progrium any update on this? Would love to see this merged in

kennethreitz commented 11 years ago

Hmmm