progval / Limnoria

A robust, full-featured, and user/programmer-friendly Python IRC bot, with many existing plugins.
https://docs.limnoria.net/
Other
618 stars 170 forks source link

protocols.http.proxy occassionally gets ignored #1349

Open Mikaela opened 5 years ago

Mikaela commented 5 years ago

I have protocols.http.proxy set to 127.0.0.1:8118 which is Privoxy listening on 127.0.0.1 and it's configured to send traffic to Tor (forward-socks5t / 127.0.0.1:9050 .).

However often web fetch https://icanhazip.com/ returns the real IP\n and web title http://expyuzz4wqqyqhjn.onion/ (www.torproject.org, see onion.torproject.org) returns <urlopen error [Errno -2] Name or service not known>.

I have confirmed that the issue is not in Privoxy configuration as curl -x http://127.0.0.1:8118 https://icanhazip.com returns IP of a Tor exit node.

Mikaela commented 3 years ago

There was a suggestion that I may have a perception error on it working sometimes and there were two interesting links.

progval commented 3 years ago

the Web plugin source code as it currently is doesn't mention the word "proxy"

it doesn't need to deal with proxies because it uses supybot.utils.web.

Mikaela commented 3 years ago

It seems to hardcode the proxy as None instead of actually reading the configured proxy?

progval commented 3 years ago

Yes, but it's overridden here: https://github.com/ProgVal/Limnoria/blob/67a39a3adbd78d8088a0bac94c47227891a54e58/src/conf.py#L1335