progval / Limnoria

A robust, full-featured, and user/programmer-friendly Python IRC bot, with many existing plugins.
https://docs.limnoria.net/
Other
622 stars 174 forks source link

Files are created in tmp dirs and they are cleaned if tests succeed (#1061) #1570

Closed GMDSantana closed 7 months ago

GMDSantana commented 7 months ago

As discussed in #1061, here we use this:

https://docs.python.org/3/library/tempfile.html#tempfile.TemporaryDirectory

to handle the creation of temporary directories. The files are not deleted in case there are any test failures, so they can be inspected.

progval commented 7 months ago

Thanks

Could you create a single temporary directory with the three test- inside it, as well as print its path? This will make it easier for people running tests to locate where the data is.

progval commented 7 months ago

Thanks!