Netsplits aren't handled properly - bot doesn't even notice them, and later spams all other networks with a lot of notices saying disconnected from <network>: Ping sent at <time>, not replied to.

progval / Limnoria

A robust, full-featured, and user/programmer-friendly Python IRC bot, with many existing plugins.

https://docs.limnoria.net/

Other

623 stars 173 forks source link

Netsplits aren't handled properly - bot doesn't even notice them, and later spams all other networks with a lot of notices saying disconnected from <network>: Ping sent at <time>, not replied to. #67

Closed Limnoria closed 11 years ago

Limnoria commented 13 years ago

Issue sent from #limnoria at freenode by nyuszika7h (registered as nyuszika7h)

ghost commented 13 years ago

Oh, and I forgot to say, that notice spamming is an issue with the Relay plugin.

-Notice- -nyuSupy/##nyuszika7h- disconnected from freenode: Ping sent at 2011-07-06T15:26:54 not replied to.
-Notice- -nyuSupy/##nyuszika7h- disconnected from freenode: Ping sent at 2011-07-06T15:26:54 not replied to.
<+[nyuszika7h]> Fail
-Notice- -nyuSupy/##nyuszika7h- disconnected from freenode: Ping sent at 2011-07-06T15:26:54 not replied to.
<+[nyuszika7h]> It was a netsplit
-Notice- -nyuSupy/##nyuszika7h- disconnected from freenode: Ping sent at 2011-07-06T15:26:54 not replied to.
-Notice- -nyuSupy/##nyuszika7h- disconnected from freenode: Ping sent at 2011-07-06T15:26:54 not replied to.
<+[nyuszika7h]> Spam
<+[nyuszika7h]> !!!
-Notice- -nyuSupy/##nyuszika7h- disconnected from freenode: Ping sent at 2011-07-06T15:26:54 not replied to.
<+[nyuszika7h]> ~quit
«--- nyuSupy (~limnoria@WiseIRC/Bot/nyuSupy) has Quit (Remote host closed the connection)

progval commented 13 years ago

This is not a netsplit, it's a down server. What should I do, exactly? Disable automatic reconnect?

Mikaela commented 13 years ago

@nyuszika7h are you connecting directly to some freenode server? I saw that flood but every else supybot/gribble/limnoria are only showing that once. Same with weird mode realying of your bot, it's the only bot which relays modes so.

ghost commented 13 years ago

@ProgVal It is a netsplit, many people on the same server have quit with *.net *.split. And that's not automatic reconnecting, it can't reconnect and ping out again, all in 1 second...

@Mkaysi chat.eu.freenode.net, but only because Twisted can't connect to {irc,chat}.freenode.net. The splitting server was jordan.freenode.net.

progval commented 13 years ago

A down server often results in a netsplit. But the bot was trying to connect to a down server, so this is the real problem.

Mikaela commented 13 years ago

@nyuszika7h chat.eu.freenode.net redirects to one of the following servers: kornbluth.freenode.net orwell.freenode.net calvino.freenode.net gibson.freenode.net leguin.freenode.net lem.freenode.net wolfe.freenode.net sendak.freenode.net jordan.freenode.net lindbohm.freenode.net holmes.freenode.net barjavel.freenode.net bartol.freenode.net pratchett.freenode.net .

@ProgVal "What should I do, exactly? Disable automatic reconnect?" You should add configuration variable to select is automatic reconnect on/off . Some people appear to need it, but I think that it's more useful that the bot will reconnect automaticly.

What would it do if it disconnects from everywhere? Would it quit or just stay as ghost which can't do anything?

progval commented 13 years ago

I think it would quit.

On Thu, Jul 7, 2011 at 12:50 AM, Mkaysi reply@reply.github.com wrote:

@nyuszika7h chat.eu.freenode.net redirects to one of the following servers: kornbluth.freenode.net orwell.freenode.net calvino.freenode.net gibson.freenode.net leguin.freenode.net lem.freenode.net wolfe.freenode.net sendak.freenode.net jordan.freenode.net lindbohm.freenode.net holmes.freenode.net barjavel.freenode.net bartol.freenode.net pratchett.freenode.net .

@ProgVal "What should I do, exactly? Disable automatic reconnect?" You should add configuration variable to select is automatic reconnect on/off . Some people appear to need it, but I think that it's more useful that the bot will reconnect automaticly.

What would it do if it disconnects from everywhere? Would it quit or just stay as ghost which can't do anything?

Reply to this email directly or view it on GitHub: https://github.com/ProgVal/Limnoria/issues/67#issuecomment-1516487

ghost commented 13 years ago

@ProgVal It didn't receive a ping reply, so it disconnected from freenode (Read error: Connection reset by peer - while most users on that server have quit with .net .split), and flooded WiseIRC with lots of notices which had the same content (see my first comment).

progval commented 13 years ago

You obviously don't understand what a netsplit is.

On Thu, Jul 7, 2011 at 9:50 AM, nyuszika7h reply@reply.github.com wrote:

@ProgVal It didn't receive a ping reply, so it disconnected from freenode (Read error: Connection reset by peer - while most users on that server have quit with \.net .split), and flooded WiseIRC with lots of notices which had the same content (see my first comment).

Reply to this email directly or view it on GitHub: https://github.com/ProgVal/Limnoria/issues/67#issuecomment-1520985

ghost commented 13 years ago

I said it wrong - it has quit with \*.net \*.split, too. I confused it with an other case when I had to kill the bot. Oh, and did you see my first comment? It told the channel many times that it disconnected from freenode - all in less than a minute! It's impossible to reconnect and ping out again so quickly, since the ping timeout is ~240 seconds (and 120 in the bot)...

Mikaela commented 12 years ago

I think that this behavior has changed nowadays or at least anyone hasn't talked about anything like this.

progval commented 11 years ago

Since I haven't seen anyone telling me about it (neither did monodemono), I'm closing this issue.

Ping me if you want me to reopen it.