search

progval / Supybot-plugins

Collection of plugins for Supybot/Limnoria I wrote or forked.
https://github.com/ProgVal/Limnoria/
108 stars 63 forks source link

GitHub: add support for secret #230

Closed Mikaela closed 8 years ago

Mikaela commented 9 years ago

If secret was supported, the plugin wouldn't need to have GitHub IP addresses hardcoded and could work with other services which use GitHub-like hooks. I am not sure if these exists, but Identica has Twitter-like API and Libravatar has Gravatar-like API.

It would also solve issue of needing plugin update after GitHub IPs change (I think this has happened at least once) or when they enable IPv6 which many users have been asking for (https://github.com/github/github-services/issues/489).

progval commented 8 years ago

Implemented in 2130c5ba9bf58e6a2253822ee3c0a2cb562d74bd.