search

progval / Supybot-plugins

Collection of plugins for Supybot/Limnoria I wrote or forked.
https://github.com/ProgVal/Limnoria/
107 stars 63 forks source link

An attempt at adding RELAYMSG support to LinkRelay #342

Closed necessary129 closed 3 years ago

necessary129 commented 3 years ago

Fixes #338

progval commented 3 years ago

Hi,

Without going into the code change itself, I do not want any of the software I maintain to emit RELAYMSG in its current state.

  1. The capability name should be vendored, not remain draft/ forever. https://ircv3.net/specs/extensions/capability-negotiation.html#draft-capabilities
  2. The NUH of PRIVMSGs generated from RELAYMSG messages is unspecified, and Ergo's current implementation makes it easy to impersonate the bot
  3. Interaction with account-tag is also unspecified, and could be used to impersonate the bot

I already made the authors of the RELAYMSG spec aware of these issues, and I will review this PR if and when this is addressed

necessary129 commented 3 years ago

Aah. ok. I'll close this PR for the moment and will open one when your demands are met.

progval commented 3 years ago

On second thought, as the RELAYMSG is unlikely to every get fixed and this is a very requested feature, let's implement it anyway.

progval commented 3 years ago

Thank. I'll sleep on it and merge tomorrow if I don't have another change of heart

progval commented 3 years ago

I didn't change my mind!