Fix For #226 - Githubissues

Nitro-Carwash commented 3 years ago

Description:

Move the recipe removal step outside of the iterator in removeAnyRecipe, removeShapedRecipe, and removeShapelessRecipe in RecipeRemover.java because removal from within the iterator indirectly writes to the underlying collection, causing it to throw a ConcurrentModificationException during startup.
Load Pam's crops and fruits by reading directly from CropRegistry and FruitRegistry, which will address the current disparity in HungerOverhaul's registry, while also automatically picking up all future crop & fruit additions.
- For fruits, this means we won't get the actual fruit block as a drop anymore (#226)
- For crops, this means there are now 21 new crops eligible for showing up in villager farms:
  - Agave, Amaranth, Arrowroot, Cassava, Chickpea, Elderberry, Flax, Green Grape, Huckleberry, Jicama, Jute, Kenaf, Kohlrabi, Lentil, Millet, Mulberry, Quinoa, Sisal, Taro, Tomatillo, and Juniper Berry
Change build Forge version to 14.23.5.2816 since that's the minimum version for jei_version=4.15.+.

Testing:

See before and after for a Hazelnut and Rambutan tree:
- Before: https://imgur.com/a/mjG2KY5
- After: https://imgur.com/a/YPWF44A
Visit some villages and make sure they are still farming Pam's crops, including some of the new ones.
Testing for the recipe removal and Forge version changes were done by simply making sure the game would make it to the title screen.

progwml6 commented 3 years ago

This is under review

alexbegt commented 3 years ago

This is good to go :)

progwml6 / HungerOverhaul