search

progwml6 / ironchest

Iron Chest minecraft mod by CPW
https://minecraft.curseforge.com/projects/iron-chests
GNU General Public License v3.0
137 stars 88 forks source link

Incompatibility with VanillaTweaks #178

Closed strikerrocker closed 5 years ago

strikerrocker commented 5 years ago

Hey i would like to ask for opinions on whose fault this issue would be https://github.com/StrikerRockers-Mods/VanillaTweaks/issues/51 essentially my mod is adding a capability to all item entities here https://github.com/StrikerRockers-Mods/VanillaTweaks/blob/1.12/src/main/java/io/github/strikerrocker/vt/events/VTEventHandler.java#L127 and iron chests creates what seems to be an dummy item entity here https://github.com/progwml6/ironchest/blob/1.12/src/main/java/cpw/mods/ironchest/client/renderer/chest/TileEntityIronChestRenderer.java#L52 passing world parameter as null and it somehow causes the issue. Any insights on this issue will be appreciated. Others opinion from MMD discord Screenshot_2019-05-13-21-37-17-1

strikerrocker commented 5 years ago

Thanks for addressing the issue.

strikerrocker commented 5 years ago

Will keep it open till an new version is released.