search

progwml6 / ironchest

Iron Chest minecraft mod by CPW
https://minecraft.curseforge.com/projects/iron-chests
GNU General Public License v3.0
135 stars 86 forks source link

[Iron Chets] Added a compatibility json file for Public Gui Announcement #204

Closed AbsolemJackdaw closed 4 years ago

AbsolemJackdaw commented 4 years ago

the PGA : https://www.curseforge.com/minecraft/mc-mods/public-gui-announcement

The Wiki on how these JSON files work : https://github.com/ArtixAllMighty/PublicGuiAnnouncement/wiki/Add-Mod-Compatibility

In this PR is contained one json file to add compatibility with the mod Public Gui Announcement. I wanted to ship the compat at first with my mod, but it would be better if the author maintains it himself. (in case of path and name changes as well addition or removal from screens).

I hereby give you all files needed to add compatibility to my mod. There is nothing else left to do apart from merging the PR.

If you have any other question, I'd be happy to answer !

P.S : I opted for the vanilla container chest image to display, because Iron Chests doesn't have different containers or screens I can use to identify each one from one another, and I didnt know which one to pick as a standard. Furthermore can resourcepacks that modify the chest container image now also show on PGA, without breaking immersion too much

progwml6 commented 4 years ago

We are highly unlikely to change this any time soon. I think this is best maintained on your side.