progwml6 / ironchest

Iron Chest minecraft mod by CPW
https://minecraft.curseforge.com/projects/iron-chests
GNU General Public License v3.0
135 stars 85 forks source link

Cystal Chests crash on open #265

Open RoyalReject opened 2 years ago

RoyalReject commented 2 years ago

Version Information

Minecraft: 1.18 Forge: 38.0.14 Iron Chests: 1.18-13.0.5

Report Information

When opening a crystal chest it crashes the game

Steps to Reproduce

Place down crystal chest in world and attempt to open

Crash Log

PasteBinLink

Zedrimar commented 2 years ago

Can confirm (also on forge *.15)

anaooz commented 2 years ago

same here (forge .16)

aurilisdev commented 2 years ago

same here forge .16

emanuele246gi commented 2 years ago

Same here, I also made an issue 5 days ago

kevin-wackman commented 2 years ago

Very reproducible, it looks like it's based on when the entity is created (opening the chest does this, as well as trying to utilize it with something pulling from the inventory. It looks like the new 1.17 (I experienced it on 1.18, but the issue looks like it's on 1.17 too) change to use an ICrystalChest interface left an unimplemented int getContainerSize(); method in both the regular and the trapped entity. Either setting a default in the interface or defining it in the respective entities should be good enough to fix it, but I can't verify that because I don't have an env set up for it.

RoyalReject commented 2 years ago

I loaded a dev env and it works but breaks once you build the solution. The crystal check extends AbstractIronChestBlockEntity which includes int getContainerSize(); have some stuff going on before I can mess with it more

Unexian commented 2 years ago

confirmed 1.18