project-akri / akri-docs

Documentation for Akri
https://docs.akri.sh/
Apache License 2.0
8 stars 21 forks source link

Added missing dependency and updated cargo version #104

Closed bindsi closed 9 months ago

bindsi commented 10 months ago
bindsi commented 9 months ago

@diconico07 thanks for your approval. Who is gonna merge this?

diconico07 commented 9 months ago

@Bindsi , I will in a few days, or some other maintainers if they take a look before that. We tend to let a bit of time for other reviewers to have another look before merging after an approval.

bindsi commented 9 months ago

the akri repo setup.sh still use 1.68.1, do we need to update rust version in code repo, too?

@johnsonshih: yeah, you are right...but I see that it is not compiling with 1.70 because dependencies require 1.68.1 and are tightly coupled to that version by the cargo.lock checked in in codebase...mmh, wondering if I should create an issue for that and trying to resolve it...wdyt?

johnsonshih commented 9 months ago

the akri repo setup.sh still use 1.68.1, do we need to update rust version in code repo, too?

@johnsonshih: yeah, you are right...but I see that it is not compiling with 1.70 because dependencies require 1.68.1 and are tightly coupled to that version by the cargo.lock checked in in codebase...mmh, wondering if I should create an issue for that and trying to resolve it...wdyt?

please create an issue to keep track of the problem, thanks! BTW, for the Cargo.lock issue, remove the Cargo.lock file or run 'cargo update' should help.

kate-goldenring commented 9 months ago

created a pr to bump to latest rust version for Akri: https://github.com/project-akri/akri/pull/679