search

project-akri / akri

A Kubernetes Resource Interface for the Edge
https://docs.akri.sh/
Apache License 2.0
1.11k stars 146 forks source link

Use the admission controller from `kube-rs` for Configuration Validation #375

Open kate-goldenring opened 3 years ago

kate-goldenring commented 3 years ago

Is your feature request related to a problem? Please describe. Now that we have updated to the latest kube-rs version in #361, we can take advantage of kube-rs's admission controller to simplify our Configuration Validating Webhook.

Ideally, using kube-rs's admission controller will make it so we do not need to host Open API specification of the Configuration CRD as done in the current implementation.

Describe the solution you'd like kube-rs has good examples) for using their admission controller.

Additional context This webhook was created initially for validating that the Configuration's components, namely that the broker PodSpec was properly formatted in the Configuration. It was made to catch formatting mistakes that would not be caught by serde serializing the configuration. Possibly, using the latest kube and k8s-openapi versions already solves this. See original issue: https://github.com/deislabs/akri/issues/180

github-actions[bot] commented 2 years ago

Issue has been automatically marked as stale due to inactivity for 90 days. Update the issue to remove label, otherwise it will be automatically closed.

kate-goldenring commented 8 months ago

@lilustga is going to look at this