Added support for Matrix Voice/Creator over ZeroMQ (Matrix Core) - Githubissues

project-alice-assistant / HermesLedControl

Provides an easy way to control your leds in an Hermes environment

GNU General Public License v3.0

83 stars 41 forks source link

Added support for Matrix Voice/Creator over ZeroMQ (Matrix Core) #123

Closed copitz closed 1 year ago

copitz commented 2 years ago

📑 Description

Added support for Matrix Voice/Creator over ZeroMQ (Matrix Core).

There's now two new hardware types available: matrixvoiceZMQ and matrixcreatorZMQ. Both make use of the options matrixIp and everloopPort.

✅ Checks

✅ My pull request adheres to the code style of this project
✅ My code requires changes to the documentation
[ ] I have updated the documentation as required
✅ All the tests have passed - which tests? :)

ℹ Additional Information

I'm fairly new to python so I would very much appreciate your feedback :smile: (esp. on interfaces/matrixcore.py and the asyncio handling there)

Thank you very much for writing and sharing this library :+1:

Psychokiller1888 commented 2 years ago

Thank you for this contribution! I'll review it asap! Well, if you're new to Python, it looks promising to say the least. You've even respected my weird code conventions and used var typing!