Added configuration file support

project-alice-assistant / HermesLedControl

Provides an easy way to control your leds in an Hermes environment

GNU General Public License v3.0

83 stars 41 forks source link

Added configuration file support #89

Closed Xenira closed 3 years ago

Xenira commented 3 years ago

Configuration file can be defined with '--hermesLedControlConfig'
Moved argument and configuration parsing into separate file
Moved default values into dictionary and applied after configuration file was read
Moved choices into dictionary to apply on both arguments and configuration file
Added default configuration file that is written when executing install.sh
Old settings should not be changed if 'don't overwrite existing parameters' is selected. Otherwise settings file is used in future.

resolves #87

Psychokiller1888 commented 3 years ago

Thank you for this! And a special thanks at respecting thaat we are using camelCase and not Pascal_Case ;)

Psychokiller1888 commented 3 years ago

Shall I wait on your other tickets before creating a new version?

Xenira commented 3 years ago

Haha, to be honest i didn't really think about the case. This is my first python project I am contributing to and most other languages I use are in camel or snake case :)

Sure, wait with the new version. Already started the other issues and will probably commit those sometime this week.

Psychokiller1888 commented 3 years ago

Yeah, usually python follows PEP8 with their weird underscores and stuff.... Can't stand that and I'm always happy when contributors don't follow PEP8 :)