project-asgard / asgard

MIT License
27 stars 20 forks source link

Change neumann to free boundary condition. #450

Open stefan-schnake opened 1 year ago

stefan-schnake commented 1 year ago

Describe the bug Neumann BCs needs to be changed to something else -- it's only a Neumann BC when using LDG for diffusion problems. In hyperbolic problems it is a free or outflow BC.

stefan-schnake commented 1 year ago

@endeve do you have any suggestions on what to rename 'N' in the code?

mkstoyanov commented 1 month ago

@stefan-schnake Let's discuss this on the next opportunity.