project-asgard / asgard

MIT License
27 stars 20 forks source link

Refactor IMEX moment calculation and add moments for 1x2v #606

Closed ckendrick closed 1 year ago

ckendrick commented 1 year ago

Please review the developer documentation on the wiki of this project that contains help and requirements.

Proposed changes

This refactors the moment calculation in IMEX to be a single lambda function calculate_moments rather than having two copies of the same code in IMEX.

This also adds initial support for calculating moments for 1x2v PDEs.

What type(s) of changes does this code introduce?

Put an x in the boxes that apply.

Does this introduce a breaking change?

What systems has this change been tested on?

Ubuntu 20.04

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.