Please review the developer documentation
on the wiki of this project that contains help and requirements.
Proposed changes
Describe what this PR changes and why. If it closes an issue, link to it here
with a supported keyword.
The size of real-space arrays may be larger than INT_MAX, causing an assertion error. Since these arrays are for an optional output, when it isn't needed we can just set their size to zero.
I also promoted the variable in dense_space_size to int64_t and check its size before returning.
This fixes #654
What type(s) of changes does this code introduce?
Put an x in the boxes that apply.
[x] Bugfix
[ ] New feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):
Does this introduce a breaking change?
[ ] Yes
[x] No
What systems has this change been tested on?
Checklist
Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.
[x] this PR is up to date with current the current state of 'develop'
[x] code added or changed in the PR has been clang-formatted
[x] this PR adds tests to cover any new code, or to catch a bug that is being fixed
Please review the developer documentation on the wiki of this project that contains help and requirements.
Proposed changes
Describe what this PR changes and why. If it closes an issue, link to it here with a supported keyword.
The size of real-space arrays may be larger than INT_MAX, causing an assertion error. Since these arrays are for an optional output, when it isn't needed we can just set their size to zero.
I also promoted the variable in dense_space_size to int64_t and check its size before returning.
This fixes #654
What type(s) of changes does this code introduce?
Put an
xin the boxes that apply.Does this introduce a breaking change?
What systems has this change been tested on?
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.