Fixes array indexing but may transpose figures

quantumsteve commented 6 months ago

Please review the developer documentation on the wiki of this project that contains help and requirements.

Proposed changes

Describe what this PR changes and why. If it closes an issue, link to it here with a supported keyword.

Fixes #675

What type(s) of changes does this code introduce?

Put an x in the boxes that apply.

[x] Bugfix
[ ] New feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Does this introduce a breaking change?

[ ] Yes
[ ] No

What systems has this change been tested on?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.

[ ] this PR is up to date with current the current state of 'develop'
[ ] code added or changed in the PR has been clang-formatted
[ ] this PR adds tests to cover any new code, or to catch a bug that is being fixed
[ ] documentation has been added (if appropriate)

mkstoyanov commented 2 months ago

@quantumsteve The BiCG is higher priority but if we're not going to get back to this one, then we should close it.

quantumsteve commented 2 months ago

Closing as the matlab interface is likely to be deprecated/removed and distributed gmres/bicgstab is a higher priority.

project-asgard / asgard