project-asgard / asgard

MIT License
27 stars 20 forks source link

Temporarily remove preconditioner #690

Closed quantumsteve closed 2 months ago

quantumsteve commented 3 months ago

Please review the developer documentation on the wiki of this project that contains help and requirements.

Proposed changes

Describe what this PR changes and why. If it closes an issue, link to it here with a supported keyword.

Temporarily disabling the preconditioner to rule out one possible reason for test failures with CUDA 12.4

What type(s) of changes does this code introduce?

Put an x in the boxes that apply.

Does this introduce a breaking change?

What systems has this change been tested on?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.

quantumsteve commented 3 months ago

@mkstoyanov The asgard-unit-cuda job is using a CUDA 12.4 container

mkstoyanov commented 3 months ago

You got it right, this replaces the preconditioner with identity. We are not merging this but it may help you isolate the CUDA issue.

quantumsteve commented 3 months ago

I marked this as draft so it's harder to accidentally merge.