search

project-asgard / asgard

MIT License
27 stars 20 forks source link

fix some math #700

Closed mkstoyanov closed 3 months ago

mkstoyanov commented 3 months ago

RMCE does not require 2 allocations and 3 loops of solution-size data.

mkstoyanov commented 3 months ago

Do we want RMSE of the vector or per element?

"mean" error means average across all elements, per-element will have to average over time or some external dimension, or it is simply an error vector of some sort. The old code did compute it down to a scalar, even if it is not obvious due to the overuse of auto