search

project-asgard / asgard

MIT License
27 stars 20 forks source link

fix osx issue with reading floats #741

Closed mkstoyanov closed 2 months ago

mkstoyanov commented 2 months ago

This should fix the issue with float precision in Mac.

Basically, the >> fails to read the double data as floats.

quantumsteve commented 2 months ago

What do you think about creating a minimal reproducible example for libc++?

mkstoyanov commented 2 months ago

@quantumsteve

I'm overriding the test requirement, we have too many tests now, we should disable the duplicates from AWS.

mkstoyanov commented 2 months ago

What do you think about creating a minimal reproducible example for libc++?

We can do that but I also want to check what the standard says too.

quantumsteve commented 2 months ago

@quantumsteve

I'm overriding the test requirement, we have too many tests now, we should disable the duplicates from A

I've disabled the duplicate tests from running on pull requests but haven't figured out why GitHub is still waiting for results from them.

mkstoyanov commented 2 months ago

@quantumsteve I'm overriding the test requirement, we have too many tests now, we should disable the duplicates from A

I've disabled the duplicate tests from running on pull requests but haven't figured out why GitHub is still waiting for results from them.

So we're waiting on tests that will never run.

Must be something in the hooks, there must be something in the github setup that is calling AWS. Maybe something in the AWS has to be force-updated ... ugh!