search

project-bitmark / bitmark

Bitmark Core
The Unlicense
47 stars 32 forks source link

TLS / SSL Updates #108

Open melvincarvalho opened 3 years ago

melvincarvalho commented 3 years ago

TLS / SSL Updates

The update for libboost and openssl has been done; branch 'ssl-only' on my github page takes care of that . It was developed as v0.9.7.3. Now that it is stable, I will soon merge it to the official master branch and tag it v0.9.7.4 and make an official release with binaries.

From @dbkeys

I've been testing here: https://github.com/project-bitmark/bitmark/issues/107

melvincarvalho commented 3 years ago

I have tested the following repo:

https://github.com/dbkeys/bitmark/tree/ssl-only

It compiled on ubuntu 20.04 and synced. It has been running a few days

It largely works fine, but I did not use it as a wallet, only to relay transactions, which does work

The following warnings were registered, but restarting fixed it

CheckForkWarningConditions: Warning: Large valid fork found
  forking the chain at height 1161364 (28f18073acd3c211312b4b1e6c6a293da85fe7d0a50366e0a96e10492a4e9368)
  lasting to height 1161365 (000000c6938a7dad2e509c37073b63e33a48ff9112ef469f734f37f6e8a16c36).
Chain state database corruption likely

error: {"code":-2,"message":"Safe mode: Warning: The network does not appear to fully agree! Some miners appear to be experiencing issues."}

I've also compiled the previous stable version 0.9.7.2 under ubuntu by downgrading libssl, however that doesnt fix the libboost issues

dbkeys commented 2 years ago

These "large valid fork" messages are triggered with a 1 block fork, which is too "hysterical" in my opinion. I think we should define what a large fork is.

melvincarvalho commented 2 years ago

Ive now been running this code base for almost a year. I can say about 5 times in the year have I got an error message, requiring a restart and then all was fine. That's good in a couples of ways, in that it can run long periods on MPOW, and also that we get a warning when something is potentially wrong. Someone else I know has run it for over half a year without any issues.

Are you 100% convinced that this is a 1 block fork, and not something else in MPOW?