Issue/1/docker compose - Githubissues

tallamjr commented 5 years ago

Attempts to Fix #1

By running docker build --tag=twitcher . (inside the twitcher/ repo) and then docker tag twitcher tallamjr/twitcher:latest followed by docker push tallamjr/twitcher I was able to push a pre-built image to DockerHub that I could later use in simurgh (with the corresponding docker-compose.yml file*) to run docker-compose up -d.

This seems to build fine and is tested on travis on issue/1/docker-compose branch.

Would this be able to be built and pushed to turinginst/twticher aswell/instead and then I could update the docker-compose.yml file to say turinginst/twitcher as opposed to tallamjr/twitcher ? (I'm assuming I do not have push rights to turinginst on DockerHub)

Then it should be the case that within simurgh, users would just need to run: docker-compose up -d, to spin up, and then docker-compose down to tear down.

p.s. many thanks to @rkm for pointing me to the original docker-compose file which helped me learn about all of this.

TODO: Include dodo as part of the complete build.

*corresponding docker-compose.yml:

version: '3'

services:
  bluesky:
    container_name: bluesky
    image: turinginst/bluesky:1.1.1
    expose:
      - 9000
      - 9001
  bluebird:
    container_name: bluebird
    depends_on:
      - bluesky
    image: turinginst/bluebird:1.2.0
    ports:
      - 5001:5001
    environment:
      - BS_HOST=bluesky
  web:
    container_name: twitcher
    depends_on:
      - bluebird
    image: tallamjr/twitcher
    command: http-server .
    ports:
      - "8080:8080"

tallamjr commented 5 years ago

Now that I am able to push builds to turinginst on Dockerhub, an update to the docker-compose.yml file has been made to be:

...
     - bluebird
    image: turinginst/twitcher
    command: http-server .
    ports:
      - "8080:8080"

With this change I will remove the [WIP] tag as this would be sufficient to merge now.

Note, with dbb8130 a new set of tests will now run which fully check integration tests of dodo in both Python and R with and without docker running

tallamjr commented 5 years ago

Fixes #1

project-bluebird / simurgh

Issue/1/docker compose #5